[Bug 613001] Review Request: Heimdal - Alternative Kerberos implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=613001



--- Comment #57 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
(In reply to Orion Poplawski from comment #56)
> So, I did a local build of this on my F20 box and it failed running the
> tests.  I notice that configure picked up a few extra things on my local
> build:

Thanks a lot for investigating this.

> +checking for CAPNG... yes
> 
> > BuildRequires:  libcap-ng-devel

I've added this in.

> -checking for crypto library... included libhcrypto
> +checking for crypto library... libcrypto
> 
> So, what to do here.  Somehow I missed that heimdal's libhcrypto is a SSL
> reimplementation, and can be swapped out for openssl.  It also appears to be
> the user of libtommath.  Do we want to use libhcrypto or openssl?  

Wow, I totally missed this. You're right. I was missing BR: openssl-devel, and
the build system wasn't erroring when I used --with-openssl. Now that I've
added the BR, libhcrypto (including libtommath) is not present.

I haven't tested the OpenSSL backend myself, but the test suite passes at
least.  That simplifies things from Fedora's perspective.

> +checking db.h usability... yes
> +checking db.h presence... yes
> +checking for db.h... yes
> +checking for db_create... yes, in -ldb
> 
> > BuildRequires:  libdb-devel (instead of db4-devel)

Great catch again. That explains the mystery of why the otp utilities were only
building on RHEL 6. I've adjusted the package to use libdb-devel on Fedora and
db4-devel on RHEL 6.

> +checking whether to enable OTP library... yes
> 
> This comes from having libdb.
> 
> Other missed items:
> 
> checking for libintl... no
> 
> Not sure why it isn't finding this.

I can't even find a package that ships libintl.so. I guess Red Hat gettext
doesn't have this.

> My rawhide build with this failed with:
> Installed (but unpackaged) file(s) found:
>    /usr/bin/otp
>    /usr/bin/otpprint
>    /usr/share/man/man1/otp.1.gz
>    /usr/share/man/man1/otpprint.1.gz
> 
> Which look to be a little too generic.

You're right. Once I sorted out the libdb-devel situation I can package those
files on both Fedora and RHEL.

Here's the new version:

* Tue Apr 29 2014 ktdreyer@xxxxxxxxxxxx - 1.6.0-0.3.20140429gitd60ba47
- Add BR libdb-devel on Fedora (RHBZ #613001)
- Add BR openssl-devel and libcap-ng-devel (RHBZ #613001)
- Only set BuildRoot on el5
- Alphabetize non-conditional BuildRequires
- Remove duplicate BR openldap-devel

Exact changes in Git:
https://gitorious.org/ktdreyer/heimdal-packaging/commit/f90e6ff63adad6303174fb27405e0834f30234ae

Spec URL: http://ktdreyer.fedorapeople.org/reviews/heimdal.spec
SRPM URL:
http://ktdreyer.fedorapeople.org/reviews/heimdal-1.6.0-0.3.20140429gitd60ba47.fc21.src.rpm

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6797256

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]