https://bugzilla.redhat.com/show_bug.cgi?id=1080583 Mukundan Ragavan <nonamedotc@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nonamedotc@xxxxxxxxx --- Comment #3 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Hi Darryl, Here is a preliminary review - Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - ldconfig called in %post and %postun if required. Note: /sbin/ldconfig not called in compat-qpid-cpp-server See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 19148800 bytes in 1154 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [?]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 16 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid- cpp/licensecheck.txt ---> This looks fine to me. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/qpid, /usr/lib64/qpid/client, /usr/lib64/qpid/daemon [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/rc.d/init.d, /usr/lib64/qpid/daemon, /usr/libexec/qpid, /etc/rc.d, /usr/lib64/qpid/client [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/qpid/examples(qpid- cpp-client-devel), /usr/share/qpid/examples/qmf-console(qpid-cpp-client- devel), /usr/lib64/qpid(qpid-cpp-client), /var/lib/qpidd(qpid-cpp- server), /usr/include/qpid/sys(qpid-cpp-client-devel), /usr/include/qpid/sys/posix(qpid-cpp-client-devel), /usr/include/qpid/messaging(qpid-cpp-client-devel), /usr/include/qpid/types(qpid-cpp-client-devel), /usr/include/qpid/framing (qpid-cpp-client-devel), /usr/include/qpid/client/amqp0_10(qpid-cpp- client-devel), /usr/include/qpid(qpid-cpp-client-devel), /usr/include/qpid/console(qpid-cpp-client-devel), /usr/include/qpid/client(qpid-cpp-client-devel), /usr/share/qpid/examples/messaging(qpid-cpp-client-devel), /usr/include/qpid/sys/windows(qpid-cpp-client-devel), /usr/include/qpid/amqp_0_10(qpid-cpp-client-devel), /usr/share/qpid/examples/qmf2(qpid-cpp-client-devel), /etc/qpid(qpid-cpp- client), /usr/include/qpid/log(qpid-cpp-client-devel), /usr/include/qpid/agent(qpid-cpp-client-devel), /usr/include/qpid/management(qpid-cpp-client-devel), /usr/include/qpid/client/no_keyword(qpid-cpp-client-devel), /usr/libexec/qpid/tests(qpid-cpp-client-devel), /usr/share/qpid(qpid-cpp- client-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package ---> See issues above. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). ---> This looks fine I think. I have to look more carefully again. [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in compat- qpid-cpp-client , compat-qpid-cpp-client-devel , compat-qpid-cpp-client- devel-docs , compat-qpid-cpp-server , compat-qpid-cpp-server-ha , compat- qpid-cpp-client-rdma , compat-qpid-cpp-server-rdma , compat-qpid-cpp- server-xml , compat-qpid-cpp-server-store , compat-qpid-tools [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. ---> Comments are present in the patches explaining their need. [ ]: The placement of pkgconfig(.pc) files are correct. Note: compat-qpid-cpp : /usr/lib64/pkgconfig/qmf2.pc [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [?]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.1.38 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.38 INFO: Mock Version: 1.1.38 Start: lock buildroot INFO: installing package(s): /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-devel-docs-0.24-3.fc21.noarch.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-ha-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-xml-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-store-0.24-3.fc21.x86_64.rpm /home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-tools-0.24-3.fc21.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '21', 'install', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-devel-docs-0.24-3.fc21.noarch.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-ha-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-xml-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-cpp-server-store-0.24-3.fc21.x86_64.rpm', '/home/mukundan/personal/pkgs/reviews/1080583-compat-qpid-cpp/results/compat-qpid-tools-0.24-3.fc21.noarch.rpm', '--setopt=tsflags=nocontexts'] No package matched to upgrade: compat-qpid-cpp-client Error: Package: compat-qpid-cpp-server-ha-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-ha-0.24-3.fc21.x86_64) Requires: qpid-cpp-server(x86-64) = 0.24-3.fc21 Available: qpid-cpp-server-0.26-2.fc21.x86_64 (fedora) qpid-cpp-server(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-server-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-0.24-3.fc21.x86_64) Requires: qpid-cpp-client(x86-64) = 0.24-3.fc21 Installing: qpid-cpp-client-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64 (/compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64) Requires: qpid-cpp-client(x86-64) = 0.24-3.fc21 Available: qpid-cpp-client-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64 (/compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64) Requires: qpid-cpp-client(x86-64) = 0.24-3.fc21 Installing: qpid-cpp-client-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64 (/compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64) Requires: qpid-cpp-client(x86-64) = 0.24-3.fc21 Installing: qpid-cpp-client-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-server-xml-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-xml-0.24-3.fc21.x86_64) Requires: qpid-cpp-server(x86-64) = 0.24-3.fc21 Available: qpid-cpp-server-0.26-2.fc21.x86_64 (fedora) qpid-cpp-server(x86-64) = 0.26-2.fc21 You could try using --skip-broken to work around the problem Error: Package: compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64) Requires: qpid-cpp-client-rdma(x86-64) = 0.24-3.fc21 Available: qpid-cpp-client-rdma-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client-rdma(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64 (/compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64) Requires: qpid-cpp-client(x86-64) = 0.24-3.fc21 Available: qpid-cpp-client-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-server-store-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-store-0.24-3.fc21.x86_64) Requires: qpid-cpp-server(x86-64) = 0.24 Available: qpid-cpp-server-0.26-2.fc21.x86_64 (fedora) qpid-cpp-server(x86-64) = 0.26-2.fc21 Error: Package: compat-qpid-cpp-server-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-0.24-3.fc21.x86_64) Requires: qpid-cpp-client(x86-64) = 0.24-3.fc21 Available: qpid-cpp-client-0.26-2.fc21.x86_64 (fedora) qpid-cpp-client(x86-64) = 0.26-2.fc21 Error: compat-qpid-cpp-client conflicts with qpid-cpp-client-0.26-2.fc21.x86_64 Error: Package: compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64 (/compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64) Requires: qpid-cpp-server(x86-64) = 0.24-3.fc21 Available: qpid-cpp-server-0.26-2.fc21.x86_64 (fedora) qpid-cpp-server(x86-64) = 0.26-2.fc21 You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: compat-qpid-cpp-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-client-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-client-devel-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-client-devel-docs-0.24-3.fc21.noarch.rpm compat-qpid-cpp-server-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-server-ha-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-client-rdma-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-server-rdma-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-server-xml-0.24-3.fc21.x86_64.rpm compat-qpid-cpp-server-store-0.24-3.fc21.x86_64.rpm compat-qpid-tools-0.24-3.fc21.noarch.rpm compat-qpid-cpp-0.24-3.fc21.src.rpm compat-qpid-cpp.x86_64: E: no-binary compat-qpid-cpp.x86_64: W: no-documentation compat-qpid-cpp.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/qmf2.pc compat-qpid-cpp-client.x86_64: W: self-obsoletion qpid-cpp-client-ssl <= 0.24 obsoletes qpid-cpp-client-ssl = 0.24 compat-qpid-cpp-client.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libqpidcommon.so compat-qpid-cpp-client.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libqpidtypes.so compat-qpid-cpp-client.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libqpidclient.so compat-qpid-cpp-client.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libqpidmessaging.so compat-qpid-cpp-client-devel.x86_64: W: no-dependency-on compat-qpid-cpp-client/compat-qpid-cpp-client-libs/libcompat-qpid-cpp-client compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qpid-topic-listener ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qpid-client-test ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qpid-latency-test ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qpid-txtest ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qpid-topic-publisher ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] compat-qpid-cpp-client-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qpid-perftest ['/builddir/build/BUILD/qpid-0.24/cpp/src', ''] compat-qpid-cpp-client-devel.x86_64: W: no-documentation compat-qpid-cpp-client-devel.x86_64: W: no-manual-page-for-binary qpid-topic-publisher compat-qpid-cpp-client-devel.x86_64: W: no-manual-page-for-binary qpid-perftest compat-qpid-cpp-client-devel.x86_64: W: no-manual-page-for-binary qpid-latency-test compat-qpid-cpp-client-devel.x86_64: W: no-manual-page-for-binary qpid-txtest compat-qpid-cpp-client-devel.x86_64: W: no-manual-page-for-binary qpid-topic-listener compat-qpid-cpp-client-devel.x86_64: W: no-manual-page-for-binary qpid-client-test compat-qpid-cpp-server.x86_64: W: self-obsoletion qpid-cpp-server-ssl <= 0.24 obsoletes qpid-cpp-server-ssl = 0.24 compat-qpid-cpp-server.x86_64: W: conffile-without-noreplace-flag /etc/qpidd.conf compat-qpid-cpp-server.x86_64: E: postin-without-ldconfig /usr/lib64/libqpidbroker.so.2.0.0 compat-qpid-cpp-server.x86_64: W: non-standard-uid /var/lib/qpidd qpidd compat-qpid-cpp-server.x86_64: W: non-standard-gid /var/lib/qpidd qpidd compat-qpid-cpp-server.x86_64: W: non-standard-uid /var/run/qpidd qpidd compat-qpid-cpp-server.x86_64: W: non-standard-gid /var/run/qpidd qpidd compat-qpid-cpp-server.x86_64: W: dangerous-command-in-%post ln compat-qpid-cpp-server.x86_64: W: dangerous-command-in-%postun ln compat-qpid-cpp-server-ha.x86_64: W: no-documentation compat-qpid-cpp-server-ha.x86_64: W: no-manual-page-for-binary qpid-ha compat-qpid-cpp-server-ha.x86_64: E: subsys-not-used /etc/rc.d/init.d/qpidd-primary compat-qpid-cpp-server-ha.x86_64: W: incoherent-init-script-name qpidd-primary ('compat-qpid-cpp-server-ha', 'compat-qpid-cpp-server-had') compat-qpid-cpp-client-rdma.x86_64: W: no-documentation compat-qpid-cpp-client-rdma.x86_64: W: devel-file-in-non-devel-package /usr/lib64/librdmawrap.so compat-qpid-cpp-server-rdma.x86_64: W: no-documentation compat-qpid-cpp-server-xml.x86_64: W: no-documentation compat-qpid-cpp-server-store.x86_64: E: explicit-lib-dependency libaio compat-qpid-cpp-server-store.x86_64: W: only-non-binary-in-usr-lib compat-qpid-cpp-server-store.x86_64: W: no-documentation compat-qpid-cpp-server-store.x86_64: W: dangling-relative-symlink /usr/lib64/qpid/daemon/store.so store.so.0.24 compat-qpid-tools.noarch: W: devel-file-in-non-devel-package /usr/bin/qpid-config compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-config compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-route compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-cluster-store compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-cluster compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-tool compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-stat compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-queue-stats compat-qpid-tools.noarch: W: no-manual-page-for-binary qpid-printevents compat-qpid-cpp.src:105: W: macro-in-comment %doc compat-qpid-cpp.src:174: W: macro-in-comment %{_datadir} compat-qpid-cpp.src:230: W: macro-in-comment %attr compat-qpid-cpp.src:230: W: macro-in-comment %config compat-qpid-cpp.src:230: W: macro-in-comment %{_localstatedir} compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig instead of obsolete and deprecated Config. compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig instead of obsolete and deprecated Config. compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig instead of obsolete and deprecated Config. compat-qpid-cpp.src: E: specfile-error -e:1:in `<main>': Use RbConfig instead of obsolete and deprecated Config. 12 packages and 0 specfiles checked; 14 errors, 47 warnings. Requires -------- compat-qpid-cpp (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/pkg-config pkgconfig(qpid) compat-qpid-cpp-client (rpmlib, GLIBC filtered): /sbin/ldconfig boost chkconfig config(compat-qpid-cpp-client) initscripts ld-linux-x86-64.so.2()(64bit) libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libnspr4.so()(64bit) libnss3.so()(64bit) libnss3.so(NSS_3.2)(64bit) libnssutil3.so()(64bit) libplc4.so()(64bit) libplds4.so()(64bit) libpthread.so.0()(64bit) libqpidclient.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidmessaging.so.2()(64bit) libqpidtypes.so.1()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libsmime3.so()(64bit) libssl3.so()(64bit) libssl3.so(NSS_3.2)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) qpid-proton-c(x86-64) rtld(GNU_HASH) compat-qpid-cpp-client-devel-docs (rpmlib, GLIBC filtered): compat-qpid-cpp-server-ha (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqpidbroker.so.2()(64bit) libqpidclient.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidmessaging.so.2()(64bit) libqpidtypes.so.1()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) qpid-cpp-server(x86-64) qpid-qmf(x86-64) rtld(GNU_HASH) compat-qpid-cpp-client-devel (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/env /usr/bin/pkg-config boost-devel boost-filesystem boost-program-options libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqpidclient.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidmessaging.so.2()(64bit) libqpidtypes.so.1()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid-devel libuuid.so.1()(64bit) python qpid-cpp-client(x86-64) rtld(GNU_HASH) compat-qpid-cpp-client-rdma (rpmlib, GLIBC filtered): /sbin/ldconfig config(compat-qpid-cpp-client-rdma) ld-linux-x86-64.so.2()(64bit) libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libibverbs.so.1()(64bit) libibverbs.so.1(IBVERBS_1.0)(64bit) libibverbs.so.1(IBVERBS_1.1)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqpidclient.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidtypes.so.1()(64bit) librdmacm.so.1()(64bit) librdmacm.so.1(RDMACM_1.0)(64bit) librdmawrap.so.2()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) qpid-cpp-client(x86-64) rtld(GNU_HASH) compat-qpid-cpp-server-store (rpmlib, GLIBC filtered): /sbin/ldconfig db4 libaio qpid-cpp-server(x86-64) compat-qpid-cpp-server-rdma (rpmlib, GLIBC filtered): /sbin/ldconfig libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libibverbs.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqpidbroker.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidtypes.so.1()(64bit) librdmacm.so.1()(64bit) librdmawrap.so.2()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) qpid-cpp-client-rdma(x86-64) qpid-cpp-server(x86-64) rtld(GNU_HASH) compat-qpid-cpp-server-xml (rpmlib, GLIBC filtered): /sbin/ldconfig libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqpidbroker.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidtypes.so.1()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libxerces-c-3.1.so()(64bit) libxqilla.so.6()(64bit) qpid-cpp-server(x86-64) rtld(GNU_HASH) xerces-c xqilla compat-qpid-tools (rpmlib, GLIBC filtered): /usr/bin/python python-qpid python-qpid-qmf compat-qpid-cpp-server (rpmlib, GLIBC filtered): /bin/sh config(compat-qpid-cpp-server) cyrus-sasl ld-linux-x86-64.so.2()(64bit) libaio.so.1()(64bit) libaio.so.1(LIBAIO_0.1)(64bit) libaio.so.1(LIBAIO_0.4)(64bit) libboost_program_options.so.1.54.0()(64bit) libboost_system.so.1.54.0()(64bit) libc.so.6()(64bit) libdb_cxx-4.8.so()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqpidbroker.so.2()(64bit) libqpidclient.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidmessaging.so.2()(64bit) libqpidtypes.so.1()(64bit) librt.so.1()(64bit) libsasl2.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libxerces-c-3.1.so()(64bit) libxqilla.so.6()(64bit) qpid-cpp-client(x86-64) qpid-proton-c(x86-64) rtld(GNU_HASH) systemd-units Provides -------- compat-qpid-cpp: compat-qpid-cpp compat-qpid-cpp(x86-64) pkgconfig(qmf2) compat-qpid-cpp-client: compat-qpid-cpp-client compat-qpid-cpp-client(x86-64) config(compat-qpid-cpp-client) libqpidclient.so.2()(64bit) libqpidcommon.so.2()(64bit) libqpidmessaging.so.2()(64bit) libqpidtypes.so.1()(64bit) qpid-cpp-client-ssl compat-qpid-cpp-client-devel-docs: compat-qpid-cpp-client-devel-docs compat-qpid-cpp-server-ha: compat-qpid-cpp-server-ha compat-qpid-cpp-server-ha(x86-64) compat-qpid-cpp-client-devel: compat-qpid-cpp-client-devel compat-qpid-cpp-client-devel(x86-64) pkgconfig(qpid) compat-qpid-cpp-client-rdma: compat-qpid-cpp-client-rdma compat-qpid-cpp-client-rdma(x86-64) config(compat-qpid-cpp-client-rdma) librdmawrap.so.2()(64bit) compat-qpid-cpp-server-store: compat-qpid-cpp-server-store compat-qpid-cpp-server-store(x86-64) compat-qpid-cpp-server-rdma: compat-qpid-cpp-server-rdma compat-qpid-cpp-server-rdma(x86-64) compat-qpid-cpp-server-xml: compat-qpid-cpp-server-xml compat-qpid-cpp-server-xml(x86-64) compat-qpid-tools: compat-qpid-tools compat-qpid-cpp-server: compat-qpid-cpp-server compat-qpid-cpp-server(x86-64) config(compat-qpid-cpp-server) libqpidbroker.so.2()(64bit) qpid-cpp-server-ssl Unversioned so-files -------------------- compat-qpid-cpp-client: /usr/lib64/libqpidclient.so compat-qpid-cpp-client: /usr/lib64/libqpidcommon.so compat-qpid-cpp-client: /usr/lib64/libqpidmessaging.so compat-qpid-cpp-client: /usr/lib64/libqpidtypes.so compat-qpid-cpp-server: /usr/lib64/qpid/daemon/ha.so compat-qpid-cpp-server: /usr/lib64/qpid/daemon/legacystore.so compat-qpid-cpp-server: /usr/lib64/qpid/daemon/store.so compat-qpid-cpp-server: /usr/lib64/qpid/daemon/xml.so compat-qpid-cpp-server-ha: /usr/lib64/qpid/daemon/ha.so compat-qpid-cpp-client-rdma: /usr/lib64/librdmawrap.so compat-qpid-cpp-client-rdma: /usr/lib64/qpid/client/rdmaconnector.so compat-qpid-cpp-server-rdma: /usr/lib64/qpid/daemon/rdma.so compat-qpid-cpp-server-xml: /usr/lib64/qpid/daemon/xml.so compat-qpid-cpp-server-store: /usr/lib64/qpid/daemon/store.so Source checksums ---------------- http://www.apache.org/dist/qpid/0.24/qpid-0.24.tar.gz : CHECKSUM(SHA256) this package : af62a8f551f3f9eb99d460f7fc417bba8d9900b9d6cf0902fc7e01a25d8c8fcd CHECKSUM(SHA256) upstream package : af62a8f551f3f9eb99d460f7fc417bba8d9900b9d6cf0902fc7e01a25d8c8fcd AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: qpid-0.24/extras/sasl/configure.ac:102, qpid-0.24/cpp/configure.ac:128 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1080583 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review