https://bugzilla.redhat.com/show_bug.cgi?id=1080583 --- Comment #2 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to Sandro Mani from comment #1) > These can be removed: > > %defattr(-,root,root,-) > > %clean > rm -rf %{buildroot} > > > The order of the sections in the spec is somehwat untypical, but I don't > think there is any guideline for that. > > > The package fails to build: > > /builddir/build/BUILD/qpid-0.24/cpp/src/qpid/ha/BrokerReplicator.cpp:351:6: > error: 'void > qpid::ha::{anonymous}::collectQueueReplicators(boost::shared_ptr<qpid:: > broker::Exchange>, std::set<boost::shared_ptr<qpid::ha::QueueReplicator> > >&)' defined but not used [-Werror=unused-function] > void collectQueueReplicators( > ^ > cc1plus: all warnings being treated as errors Thank you for taking on the review and the feedback. * I've removed the defattr lines * I've removed the clean stanza * I've rebased a few patches from upstream that removed the dead code Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6790196 Updated spec: http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp-0.24-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review