[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080411

Jan Kundrát <jkt@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jkt@xxxxxxxxxx



--- Comment #10 from Jan Kundrát <jkt@xxxxxxxxxx> ---
> ragel is in Fedora repo, you should use that one as BR.

There's a small problem with that -- Ragel uses host's type sizes and
signedness when generating the .cpp file, which breaks the build when
cross-compiling on amd64 for arm because amd64's "char" can store 0-255, while
the ARM's one is -128-127. I reported this to Ragel developers [1], but the fix
is still not integrated AFAIK. I don't think that would affect native builds,
though, so perhaps it's OK to use this in Fedora.

> $ ctest -j 4 --output-on-failure
>
> So I think you can use smp flags here(you can have a try)

Note that it uses a different syntax from make -- "-j 4" vs make's "-j4".

Also be careful and do not activate parallel tests on build environments where
the system is under heavy load. Some of these tests operate on QTimers with a
deadline on the order of 20ms. I've seen problems with Ubuntu's build farm
which was fixed by switching to serial invocation of these tests.

> Bug 332578 - superfluous x-test language
> [https://bugs.kde.org/show_bug.cgi?id=332578]

Fixed now, will be fixed in the next release.

> Bug 332579 - unversioned plugins library (rpmlint invalid-soname issue)
> [https://bugs.kde.org/show_bug.cgi?id=332579]

Patches for this are welcome; I'm not that much familiar with cmake to know
what a perfect fix is.

[1] http://thread.gmane.org/gmane.comp.parsers.ragel.user/933

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]