https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #9 from Christopher Meng <cickumqt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2)", "LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL (v2 or later)", "Unknown or generated", "BSD (3 clause)". 65 files have unknown license. Detailed output of licensecheck: BSD (3 clause) -------------- trojita-0.4.1/src/Imap/Model/FindInterestingPart.cpp trojita-0.4.1/src/Imap/Model/FindInterestingPart.h trojita-0.4.1/src/Imap/Model/MailboxFinder.cpp trojita-0.4.1/src/Imap/Model/MailboxFinder.h trojita-0.4.1/src/XtConnect/MailSynchronizer.cpp trojita-0.4.1/src/XtConnect/MailSynchronizer.h trojita-0.4.1/src/XtConnect/MessageDownloader.cpp trojita-0.4.1/src/XtConnect/MessageDownloader.h trojita-0.4.1/src/XtConnect/SqlStorage.cpp trojita-0.4.1/src/XtConnect/SqlStorage.h trojita-0.4.1/src/XtConnect/XtConnect.cpp trojita-0.4.1/src/XtConnect/XtConnect.h trojita-0.4.1/src/XtConnect/main.cpp GPL --- trojita-0.4.1/src/AbookAddressbook/AbookAddressbook.cpp trojita-0.4.1/src/AbookAddressbook/AbookAddressbook.h trojita-0.4.1/src/AbookAddressbook/be-contacts.cpp trojita-0.4.1/src/AbookAddressbook/be-contacts.h trojita-0.4.1/src/AppVersion/SetCoreApplication.cpp trojita-0.4.1/src/AppVersion/SetCoreApplication.h trojita-0.4.1/src/Common/Application.cpp trojita-0.4.1/src/Common/Application.h trojita-0.4.1/src/Common/ConnectionId.cpp trojita-0.4.1/src/Common/ConnectionId.h trojita-0.4.1/src/Common/ConnectionMethod.h trojita-0.4.1/src/Common/DeleteAfter.cpp trojita-0.4.1/src/Common/DeleteAfter.h trojita-0.4.1/src/Common/FileLogger.cpp trojita-0.4.1/src/Common/FileLogger.h trojita-0.4.1/src/Common/FindWithUnknown.h trojita-0.4.1/src/Common/InvokeMethod.h trojita-0.4.1/src/Common/Logging.h trojita-0.4.1/src/Common/MetaTypes.cpp trojita-0.4.1/src/Common/MetaTypes.h trojita-0.4.1/src/Common/Paths.cpp trojita-0.4.1/src/Common/Paths.h trojita-0.4.1/src/Common/PortNumbers.h trojita-0.4.1/src/Common/RingBuffer.h trojita-0.4.1/src/Common/SettingsCategoryGuard.h trojita-0.4.1/src/Common/SettingsNames.cpp trojita-0.4.1/src/Common/SettingsNames.h trojita-0.4.1/src/Common/SqlTransactionAutoAborter.h trojita-0.4.1/src/Composer/ComposerAttachments.cpp trojita-0.4.1/src/Composer/ComposerAttachments.h trojita-0.4.1/src/Composer/ContentDisposition.h trojita-0.4.1/src/Composer/MessageComposer.cpp trojita-0.4.1/src/Composer/MessageComposer.h trojita-0.4.1/src/Composer/PlainTextFormatter.cpp trojita-0.4.1/src/Composer/PlainTextFormatter.h trojita-0.4.1/src/Composer/Recipients.cpp trojita-0.4.1/src/Composer/Recipients.h trojita-0.4.1/src/Composer/ReplaceSignature.cpp trojita-0.4.1/src/Composer/ReplaceSignature.h trojita-0.4.1/src/Composer/SenderIdentitiesModel.cpp trojita-0.4.1/src/Composer/SenderIdentitiesModel.h trojita-0.4.1/src/Composer/SubjectMangling.cpp trojita-0.4.1/src/Composer/SubjectMangling.h trojita-0.4.1/src/Composer/Submission.cpp trojita-0.4.1/src/Composer/Submission.h trojita-0.4.1/src/Gui/AbstractAddressbook.h trojita-0.4.1/src/Gui/AbstractPartWidget.h trojita-0.4.1/src/Gui/AttachmentView.cpp trojita-0.4.1/src/Gui/AttachmentView.h trojita-0.4.1/src/Gui/AutoCompletion.cpp trojita-0.4.1/src/Gui/AutoCompletion.h trojita-0.4.1/src/Gui/CompleteMessageWidget.cpp trojita-0.4.1/src/Gui/CompleteMessageWidget.h trojita-0.4.1/src/Gui/ComposeWidget.cpp trojita-0.4.1/src/Gui/ComposeWidget.h trojita-0.4.1/src/Gui/ComposerAttachmentsList.cpp trojita-0.4.1/src/Gui/ComposerAttachmentsList.h trojita-0.4.1/src/Gui/ComposerTextEdit.cpp trojita-0.4.1/src/Gui/ComposerTextEdit.h trojita-0.4.1/src/Gui/EmbeddedWebView.cpp trojita-0.4.1/src/Gui/EmbeddedWebView.h trojita-0.4.1/src/Gui/EnvelopeView.cpp trojita-0.4.1/src/Gui/EnvelopeView.h trojita-0.4.1/src/Gui/ExternalElementsWidget.cpp trojita-0.4.1/src/Gui/ExternalElementsWidget.h trojita-0.4.1/src/Gui/FindBar.cpp trojita-0.4.1/src/Gui/FindBar.h trojita-0.4.1/src/Gui/FromAddressProxyModel.cpp trojita-0.4.1/src/Gui/FromAddressProxyModel.h trojita-0.4.1/src/Gui/IconLoader.h trojita-0.4.1/src/Gui/LoadablePartWidget.cpp trojita-0.4.1/src/Gui/LoadablePartWidget.h trojita-0.4.1/src/Gui/MailBoxTreeView.cpp trojita-0.4.1/src/Gui/MailBoxTreeView.h trojita-0.4.1/src/Gui/MessageListWidget.cpp trojita-0.4.1/src/Gui/MessageListWidget.h trojita-0.4.1/src/Gui/MessageSourceWidget.cpp trojita-0.4.1/src/Gui/MessageSourceWidget.h trojita-0.4.1/src/Gui/MessageView.cpp trojita-0.4.1/src/Gui/MessageView.h trojita-0.4.1/src/Gui/MsgListView.cpp trojita-0.4.1/src/Gui/MsgListView.h trojita-0.4.1/src/Gui/OnePanelAtTimeWidget.cpp trojita-0.4.1/src/Gui/OnePanelAtTimeWidget.h trojita-0.4.1/src/Gui/OverlayWidget.cpp trojita-0.4.1/src/Gui/OverlayWidget.h trojita-0.4.1/src/Gui/PartWidget.cpp trojita-0.4.1/src/Gui/PartWidget.h trojita-0.4.1/src/Gui/PartWidgetFactory.cpp trojita-0.4.1/src/Gui/PartWidgetFactory.h trojita-0.4.1/src/Gui/PasswordDialog.cpp trojita-0.4.1/src/Gui/PasswordDialog.h trojita-0.4.1/src/Gui/ProgressPopUp.cpp trojita-0.4.1/src/Gui/ProgressPopUp.h trojita-0.4.1/src/Gui/ProtocolLoggerWidget.cpp trojita-0.4.1/src/Gui/ProtocolLoggerWidget.h trojita-0.4.1/src/Gui/ReplaceCharValidator.cpp trojita-0.4.1/src/Gui/ReplaceCharValidator.h trojita-0.4.1/src/Gui/SettingsDialog.cpp trojita-0.4.1/src/Gui/SettingsDialog.h trojita-0.4.1/src/Gui/ShortcutHandler/ShortcutConfigDialog.cpp trojita-0.4.1/src/Gui/ShortcutHandler/ShortcutConfigDialog.h trojita-0.4.1/src/Gui/ShortcutHandler/ShortcutConfigWidget.cpp trojita-0.4.1/src/Gui/ShortcutHandler/ShortcutConfigWidget.h trojita-0.4.1/src/Gui/ShortcutHandler/ShortcutHandler.cpp trojita-0.4.1/src/Gui/ShortcutHandler/ShortcutHandler.h trojita-0.4.1/src/Gui/SimplePartWidget.cpp trojita-0.4.1/src/Gui/SimplePartWidget.h trojita-0.4.1/src/Gui/Spinner.cpp trojita-0.4.1/src/Gui/Spinner.h trojita-0.4.1/src/Gui/TaskProgressIndicator.cpp trojita-0.4.1/src/Gui/TaskProgressIndicator.h trojita-0.4.1/src/Gui/UserAgentWebPage.cpp trojita-0.4.1/src/Gui/UserAgentWebPage.h trojita-0.4.1/src/Gui/Util.cpp trojita-0.4.1/src/Gui/Util.h trojita-0.4.1/src/Gui/Window.cpp trojita-0.4.1/src/Gui/Window.h trojita-0.4.1/src/Gui/main.cpp trojita-0.4.1/src/Harmattan/main.cpp trojita-0.4.1/src/Imap/ConnectionState.cpp trojita-0.4.1/src/Imap/ConnectionState.h trojita-0.4.1/src/Imap/Encoders.cpp trojita-0.4.1/src/Imap/Encoders.h trojita-0.4.1/src/Imap/Exceptions.cpp trojita-0.4.1/src/Imap/Exceptions.h trojita-0.4.1/src/Imap/Model/Cache.cpp trojita-0.4.1/src/Imap/Model/Cache.h trojita-0.4.1/src/Imap/Model/CacheLoadingMode.h trojita-0.4.1/src/Imap/Model/CatenateData.h trojita-0.4.1/src/Imap/Model/CombinedCache.cpp trojita-0.4.1/src/Imap/Model/CombinedCache.h trojita-0.4.1/src/Imap/Model/CopyMoveOperation.h trojita-0.4.1/src/Imap/Model/DiskPartCache.cpp trojita-0.4.1/src/Imap/Model/DiskPartCache.h trojita-0.4.1/src/Imap/Model/DragAndDrop.cpp trojita-0.4.1/src/Imap/Model/DragAndDrop.h trojita-0.4.1/src/Imap/Model/FlagsOperation.cpp trojita-0.4.1/src/Imap/Model/FlagsOperation.h trojita-0.4.1/src/Imap/Model/FullMessageCombiner.cpp trojita-0.4.1/src/Imap/Model/FullMessageCombiner.h trojita-0.4.1/src/Imap/Model/ImapAccess.cpp trojita-0.4.1/src/Imap/Model/ImapAccess.h trojita-0.4.1/src/Imap/Model/ItemRoles.h trojita-0.4.1/src/Imap/Model/MailboxMetadata.cpp trojita-0.4.1/src/Imap/Model/MailboxMetadata.h trojita-0.4.1/src/Imap/Model/MailboxModel.cpp trojita-0.4.1/src/Imap/Model/MailboxModel.h trojita-0.4.1/src/Imap/Model/MailboxTree.cpp trojita-0.4.1/src/Imap/Model/MailboxTree.h trojita-0.4.1/src/Imap/Model/MailboxTreeFwd.h trojita-0.4.1/src/Imap/Model/MemoryCache.cpp trojita-0.4.1/src/Imap/Model/MemoryCache.h trojita-0.4.1/src/Imap/Model/Model.cpp trojita-0.4.1/src/Imap/Model/Model.h trojita-0.4.1/src/Imap/Model/ModelWatcher.cpp trojita-0.4.1/src/Imap/Model/ModelWatcher.h trojita-0.4.1/src/Imap/Model/MsgListModel.cpp trojita-0.4.1/src/Imap/Model/MsgListModel.h trojita-0.4.1/src/Imap/Model/NetworkPolicy.h trojita-0.4.1/src/Imap/Model/NetworkWatcher.cpp trojita-0.4.1/src/Imap/Model/NetworkWatcher.h trojita-0.4.1/src/Imap/Model/OneMessageModel.cpp trojita-0.4.1/src/Imap/Model/OneMessageModel.h trojita-0.4.1/src/Imap/Model/ParserState.cpp trojita-0.4.1/src/Imap/Model/ParserState.h trojita-0.4.1/src/Imap/Model/PrettyMailboxModel.cpp trojita-0.4.1/src/Imap/Model/PrettyMailboxModel.h trojita-0.4.1/src/Imap/Model/PrettyMsgListModel.cpp trojita-0.4.1/src/Imap/Model/PrettyMsgListModel.h trojita-0.4.1/src/Imap/Model/QAIM_reset.h trojita-0.4.1/src/Imap/Model/SQLCache.cpp trojita-0.4.1/src/Imap/Model/SQLCache.h trojita-0.4.1/src/Imap/Model/SpecialFlagNames.cpp trojita-0.4.1/src/Imap/Model/SpecialFlagNames.h trojita-0.4.1/src/Imap/Model/SubscribeUnSubscribeOperation.h trojita-0.4.1/src/Imap/Model/SubtreeModel.cpp trojita-0.4.1/src/Imap/Model/SubtreeModel.h trojita-0.4.1/src/Imap/Model/TaskFactory.cpp trojita-0.4.1/src/Imap/Model/TaskFactory.h trojita-0.4.1/src/Imap/Model/TaskPresentationModel.cpp trojita-0.4.1/src/Imap/Model/TaskPresentationModel.h trojita-0.4.1/src/Imap/Model/ThreadingMsgListModel.cpp trojita-0.4.1/src/Imap/Model/ThreadingMsgListModel.h trojita-0.4.1/src/Imap/Model/UidSubmitData.h trojita-0.4.1/src/Imap/Model/Utils.cpp trojita-0.4.1/src/Imap/Model/Utils.h trojita-0.4.1/src/Imap/Model/VisibleTasksModel.cpp trojita-0.4.1/src/Imap/Model/VisibleTasksModel.h trojita-0.4.1/src/Imap/Network/FileDownloadManager.cpp trojita-0.4.1/src/Imap/Network/FileDownloadManager.h trojita-0.4.1/src/Imap/Network/ForbiddenReply.cpp trojita-0.4.1/src/Imap/Network/ForbiddenReply.h trojita-0.4.1/src/Imap/Network/MsgPartNetAccessManager.h trojita-0.4.1/src/Imap/Network/MsgPartNetworkReply.cpp trojita-0.4.1/src/Imap/Network/MsgPartNetworkReply.h trojita-0.4.1/src/Imap/Parser/Command.cpp trojita-0.4.1/src/Imap/Parser/Command.h trojita-0.4.1/src/Imap/Parser/Data.cpp trojita-0.4.1/src/Imap/Parser/Data.h trojita-0.4.1/src/Imap/Parser/LowLevelParser.cpp trojita-0.4.1/src/Imap/Parser/LowLevelParser.h trojita-0.4.1/src/Imap/Parser/MailAddress.cpp trojita-0.4.1/src/Imap/Parser/MailAddress.h trojita-0.4.1/src/Imap/Parser/Message.cpp trojita-0.4.1/src/Imap/Parser/Message.h trojita-0.4.1/src/Imap/Parser/Parser.cpp trojita-0.4.1/src/Imap/Parser/Parser.h trojita-0.4.1/src/Imap/Parser/Response.cpp trojita-0.4.1/src/Imap/Parser/Response.h trojita-0.4.1/src/Imap/Parser/Rfc5322HeaderParser.cpp trojita-0.4.1/src/Imap/Parser/Rfc5322HeaderParser.generated.cpp trojita-0.4.1/src/Imap/Parser/Rfc5322HeaderParser.h trojita-0.4.1/src/Imap/Parser/Sequence.cpp trojita-0.4.1/src/Imap/Parser/Sequence.h trojita-0.4.1/src/Imap/Parser/ThreadingNode.cpp trojita-0.4.1/src/Imap/Parser/ThreadingNode.h trojita-0.4.1/src/Imap/Tasks/AppendTask.cpp trojita-0.4.1/src/Imap/Tasks/AppendTask.h trojita-0.4.1/src/Imap/Tasks/CopyMoveMessagesTask.cpp trojita-0.4.1/src/Imap/Tasks/CopyMoveMessagesTask.h trojita-0.4.1/src/Imap/Tasks/CreateMailboxTask.cpp trojita-0.4.1/src/Imap/Tasks/CreateMailboxTask.h trojita-0.4.1/src/Imap/Tasks/DeleteMailboxTask.cpp trojita-0.4.1/src/Imap/Tasks/DeleteMailboxTask.h trojita-0.4.1/src/Imap/Tasks/EnableTask.cpp trojita-0.4.1/src/Imap/Tasks/EnableTask.h trojita-0.4.1/src/Imap/Tasks/ExpungeMailboxTask.cpp trojita-0.4.1/src/Imap/Tasks/ExpungeMailboxTask.h trojita-0.4.1/src/Imap/Tasks/ExpungeMessagesTask.cpp trojita-0.4.1/src/Imap/Tasks/ExpungeMessagesTask.h trojita-0.4.1/src/Imap/Tasks/Fake_ListChildMailboxesTask.cpp trojita-0.4.1/src/Imap/Tasks/Fake_ListChildMailboxesTask.h trojita-0.4.1/src/Imap/Tasks/Fake_OpenConnectionTask.cpp trojita-0.4.1/src/Imap/Tasks/Fake_OpenConnectionTask.h trojita-0.4.1/src/Imap/Tasks/FetchMsgMetadataTask.cpp trojita-0.4.1/src/Imap/Tasks/FetchMsgMetadataTask.h trojita-0.4.1/src/Imap/Tasks/FetchMsgPartTask.cpp trojita-0.4.1/src/Imap/Tasks/FetchMsgPartTask.h trojita-0.4.1/src/Imap/Tasks/GenUrlAuthTask.cpp trojita-0.4.1/src/Imap/Tasks/GenUrlAuthTask.h trojita-0.4.1/src/Imap/Tasks/GetAnyConnectionTask.cpp trojita-0.4.1/src/Imap/Tasks/GetAnyConnectionTask.h trojita-0.4.1/src/Imap/Tasks/IdTask.cpp trojita-0.4.1/src/Imap/Tasks/IdTask.h trojita-0.4.1/src/Imap/Tasks/IdleLauncher.cpp trojita-0.4.1/src/Imap/Tasks/IdleLauncher.h trojita-0.4.1/src/Imap/Tasks/ImapTask.cpp trojita-0.4.1/src/Imap/Tasks/ImapTask.h trojita-0.4.1/src/Imap/Tasks/KeepMailboxOpenTask.cpp trojita-0.4.1/src/Imap/Tasks/KeepMailboxOpenTask.h trojita-0.4.1/src/Imap/Tasks/ListChildMailboxesTask.cpp trojita-0.4.1/src/Imap/Tasks/ListChildMailboxesTask.h trojita-0.4.1/src/Imap/Tasks/NoopTask.cpp trojita-0.4.1/src/Imap/Tasks/NoopTask.h trojita-0.4.1/src/Imap/Tasks/NumberOfMessagesTask.cpp trojita-0.4.1/src/Imap/Tasks/NumberOfMessagesTask.h trojita-0.4.1/src/Imap/Tasks/ObtainSynchronizedMailboxTask.cpp trojita-0.4.1/src/Imap/Tasks/ObtainSynchronizedMailboxTask.h trojita-0.4.1/src/Imap/Tasks/OfflineConnectionTask.cpp trojita-0.4.1/src/Imap/Tasks/OfflineConnectionTask.h trojita-0.4.1/src/Imap/Tasks/OpenConnectionTask.cpp trojita-0.4.1/src/Imap/Tasks/OpenConnectionTask.h trojita-0.4.1/src/Imap/Tasks/SortTask.cpp trojita-0.4.1/src/Imap/Tasks/SortTask.h trojita-0.4.1/src/Imap/Tasks/SubscribeUnsubscribeTask.cpp trojita-0.4.1/src/Imap/Tasks/SubscribeUnsubscribeTask.h trojita-0.4.1/src/Imap/Tasks/ThreadTask.cpp trojita-0.4.1/src/Imap/Tasks/ThreadTask.h trojita-0.4.1/src/Imap/Tasks/UidSubmitTask.cpp trojita-0.4.1/src/Imap/Tasks/UidSubmitTask.h trojita-0.4.1/src/Imap/Tasks/UnSelectTask.cpp trojita-0.4.1/src/Imap/Tasks/UnSelectTask.h trojita-0.4.1/src/Imap/Tasks/UpdateFlagsOfAllMessagesTask.cpp trojita-0.4.1/src/Imap/Tasks/UpdateFlagsOfAllMessagesTask.h trojita-0.4.1/src/Imap/Tasks/UpdateFlagsTask.cpp trojita-0.4.1/src/Imap/Tasks/UpdateFlagsTask.h trojita-0.4.1/src/MSA/AbstractMSA.cpp trojita-0.4.1/src/MSA/AbstractMSA.h trojita-0.4.1/src/MSA/FakeMSA.cpp trojita-0.4.1/src/MSA/FakeMSA.h trojita-0.4.1/src/MSA/ImapSubmit.cpp trojita-0.4.1/src/MSA/ImapSubmit.h trojita-0.4.1/src/MSA/SMTP.cpp trojita-0.4.1/src/MSA/SMTP.h trojita-0.4.1/src/MSA/Sendmail.cpp trojita-0.4.1/src/MSA/Sendmail.h trojita-0.4.1/src/Plugins/AddressbookPlugin.cpp trojita-0.4.1/src/Plugins/AddressbookPlugin.h trojita-0.4.1/src/Plugins/PasswordPlugin.cpp trojita-0.4.1/src/Plugins/PasswordPlugin.h trojita-0.4.1/src/Plugins/PluginInterface.h trojita-0.4.1/src/Plugins/PluginJob.cpp trojita-0.4.1/src/Plugins/PluginJob.h trojita-0.4.1/src/Plugins/PluginManager.cpp trojita-0.4.1/src/Plugins/PluginManager.h trojita-0.4.1/src/Streams/DeletionWatcher.cpp trojita-0.4.1/src/Streams/DeletionWatcher.h trojita-0.4.1/src/Streams/FakeSocket.cpp trojita-0.4.1/src/Streams/FakeSocket.h trojita-0.4.1/src/Streams/IODeviceSocket.cpp trojita-0.4.1/src/Streams/IODeviceSocket.h trojita-0.4.1/src/Streams/Socket.cpp trojita-0.4.1/src/Streams/Socket.h trojita-0.4.1/src/Streams/SocketFactory.cpp trojita-0.4.1/src/Streams/SocketFactory.h trojita-0.4.1/src/Streams/TrojitaZlibStatus.h trojita-0.4.1/src/XtConnect/XtCache.cpp trojita-0.4.1/src/XtConnect/XtCache.h trojita-0.4.1/src/be.contacts/main.cpp trojita-0.4.1/tests/Composer/test_Composer_Submission.cpp trojita-0.4.1/tests/Composer/test_Composer_Submission.h trojita-0.4.1/tests/Composer/test_Composer_responses.cpp trojita-0.4.1/tests/Composer/test_Composer_responses.h trojita-0.4.1/tests/Composer/test_Html_formatting.cpp trojita-0.4.1/tests/Composer/test_Html_formatting.h trojita-0.4.1/tests/Imap/test_Imap_BodyParts.cpp trojita-0.4.1/tests/Imap/test_Imap_BodyParts.h trojita-0.4.1/tests/Imap/test_Imap_CopyAndFlagOperations.cpp trojita-0.4.1/tests/Imap/test_Imap_CopyAndFlagOperations.h trojita-0.4.1/tests/Imap/test_Imap_DisappearingMailboxes.cpp trojita-0.4.1/tests/Imap/test_Imap_DisappearingMailboxes.h trojita-0.4.1/tests/Imap/test_Imap_Idle.cpp trojita-0.4.1/tests/Imap/test_Imap_Idle.h trojita-0.4.1/tests/Imap/test_Imap_LowLevelParser.cpp trojita-0.4.1/tests/Imap/test_Imap_LowLevelParser.h trojita-0.4.1/tests/Imap/test_Imap_Message.cpp trojita-0.4.1/tests/Imap/test_Imap_Message.h trojita-0.4.1/tests/Imap/test_Imap_Model.cpp trojita-0.4.1/tests/Imap/test_Imap_Model.h trojita-0.4.1/tests/Imap/test_Imap_Offline.cpp trojita-0.4.1/tests/Imap/test_Imap_Offline.h trojita-0.4.1/tests/Imap/test_Imap_Parser_parse.cpp trojita-0.4.1/tests/Imap/test_Imap_Parser_parse.h trojita-0.4.1/tests/Imap/test_Imap_Responses.cpp trojita-0.4.1/tests/Imap/test_Imap_Responses.h trojita-0.4.1/tests/Imap/test_Imap_SelectedMailboxUpdates.cpp trojita-0.4.1/tests/Imap/test_Imap_SelectedMailboxUpdates.h trojita-0.4.1/tests/Imap/test_Imap_Tasks_CreateMailbox.cpp trojita-0.4.1/tests/Imap/test_Imap_Tasks_CreateMailbox.h trojita-0.4.1/tests/Imap/test_Imap_Tasks_DeleteMailbox.cpp trojita-0.4.1/tests/Imap/test_Imap_Tasks_DeleteMailbox.h trojita-0.4.1/tests/Imap/test_Imap_Tasks_ListChildMailboxes.cpp trojita-0.4.1/tests/Imap/test_Imap_Tasks_ListChildMailboxes.h trojita-0.4.1/tests/Imap/test_Imap_Tasks_ObtainSynchronizedMailbox.cpp trojita-0.4.1/tests/Imap/test_Imap_Tasks_ObtainSynchronizedMailbox.h trojita-0.4.1/tests/Imap/test_Imap_Tasks_OpenConnection.cpp trojita-0.4.1/tests/Imap/test_Imap_Tasks_OpenConnection.h trojita-0.4.1/tests/Imap/test_Imap_Threading.cpp trojita-0.4.1/tests/Imap/test_Imap_Threading.h trojita-0.4.1/tests/Misc/test_Rfc5322.cpp trojita-0.4.1/tests/Misc/test_Rfc5322.h trojita-0.4.1/tests/Misc/test_RingBuffer.cpp trojita-0.4.1/tests/Misc/test_RingBuffer.h trojita-0.4.1/tests/Misc/test_SenderIdentitiesModel.cpp trojita-0.4.1/tests/Misc/test_SenderIdentitiesModel.h trojita-0.4.1/tests/Misc/test_SqlCache.cpp trojita-0.4.1/tests/Misc/test_SqlCache.h trojita-0.4.1/tests/Misc/test_algorithms.cpp trojita-0.4.1/tests/Misc/test_algorithms.h trojita-0.4.1/tests/Utils/FakeCapabilitiesInjector.h trojita-0.4.1/tests/Utils/LibMailboxSync.cpp trojita-0.4.1/tests/Utils/LibMailboxSync.h trojita-0.4.1/tests/Utils/ModelEvents.cpp trojita-0.4.1/tests/Utils/ModelEvents.h trojita-0.4.1/tests/Utils/TagGenerator.h trojita-0.4.1/tests/Utils/headless_test.h LGPL (v2 or later) ------------------ trojita-0.4.1/src/Imap/Model/kdeui-itemviews/kbihash_p.h trojita-0.4.1/src/Imap/Model/kdeui-itemviews/kdescendantsproxymodel.cpp trojita-0.4.1/src/Imap/Model/kdeui-itemviews/kdescendantsproxymodel.h trojita-0.4.1/src/Imap/Parser/3rdparty/rfccodecs.cpp trojita-0.4.1/src/Imap/Parser/3rdparty/rfccodecs.h trojita-0.4.1/src/QmlSupport/QNAMWebView/plugin.cpp trojita-0.4.1/src/QmlSupport/QNAMWebView/plugin.h trojita-0.4.1/src/QmlSupport/QNAMWebView/qdeclarativewebview.cpp trojita-0.4.1/src/QmlSupport/QNAMWebView/qdeclarativewebview_p.h trojita-0.4.1/tests/Misc/test_rfccodecs.h LGPL (v2) --------- trojita-0.4.1/src/Imap/Parser/3rdparty/kcodecs.cpp trojita-0.4.1/src/Imap/Parser/3rdparty/kcodecs.h trojita-0.4.1/tests/Misc/test_rfccodecs.cpp LGPL (v2.1 or later) (with incorrect FSF address) ------------------------------------------------- trojita-0.4.1/src/XtConnect/xsqlquery.cpp trojita-0.4.1/src/XtConnect/xsqlquery.h Unknown or generated -------------------- trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-alignof.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-auto.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-auto_fail_compile.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-class_override_final.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-class_override_final_fail_compile.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-constexpr.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-cstdint_header.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-decltype.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-defaulted_functions.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-deleted_functions.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-deleted_functions_fail_compile.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-func_identifier.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-initializer_list.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-lambda.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-long_long.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-nullptr.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-nullptr_fail_compile.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-rvalue_references.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-sizeof_member.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-static_assert.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-static_assert_fail_compile.cxx trojita-0.4.1/cmake/FindCXXFeatures/cxx11-test-variadic_templates.cxx trojita-0.4.1/src/Gui/FlowLayout.cpp trojita-0.4.1/src/Gui/FlowLayout.h trojita-0.4.1/src/Gui/LineEdit.cpp trojita-0.4.1/src/Gui/LineEdit.h trojita-0.4.1/src/Gui/TagListWidget.cpp trojita-0.4.1/src/Gui/TagListWidget.h trojita-0.4.1/src/Gui/TagWidget.cpp trojita-0.4.1/src/Gui/TagWidget.h trojita-0.4.1/src/Harmattan/qmlapplicationviewer/qmlapplicationviewer.cpp trojita-0.4.1/src/Harmattan/qmlapplicationviewer/qmlapplicationviewer.h trojita-0.4.1/src/Imap/Model/ModelTest/modeltest.cpp trojita-0.4.1/src/Imap/Model/ModelTest/modeltest.h trojita-0.4.1/src/Imap/Network/MsgPartNetAccessManager.cpp trojita-0.4.1/src/Imap/Parser/regenerate-ragel.sh trojita-0.4.1/src/Streams/3rdparty/rfc1951.cpp trojita-0.4.1/src/Streams/3rdparty/rfc1951.h trojita-0.4.1/src/mimetypes-qt4/io/qstandardpaths.cpp trojita-0.4.1/src/mimetypes-qt4/io/qstandardpaths.h trojita-0.4.1/src/mimetypes-qt4/io/qstandardpaths_mac.cpp trojita-0.4.1/src/mimetypes-qt4/io/qstandardpaths_os2.cpp trojita-0.4.1/src/mimetypes-qt4/io/qstandardpaths_unix.cpp trojita-0.4.1/src/mimetypes-qt4/io/qstandardpaths_win.cpp trojita-0.4.1/src/mimetypes-qt4/io/qsystemlibrary_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimedatabase.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimedatabase.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimedatabase_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimeglobpattern.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimeglobpattern_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimemagicrule.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimemagicrule_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimemagicrulematcher.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimemagicrulematcher_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimeprovider.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimeprovider_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimetype.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimetype.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimetype_p.h trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimetypeparser.cpp trojita-0.4.1/src/mimetypes-qt4/mimetypes/qmimetypeparser_p.h trojita-0.4.1/src/qwwsmtpclient/qwwsmtpclient.cpp trojita-0.4.1/src/qwwsmtpclient/qwwsmtpclient.h trojita-0.4.1/tests/imap-folder-sync/1.sh trojita-0.4.1/tests/imap-folder-sync/2.sh [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme, fedora-logos, eom), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora- logos, eom, hexchat), /usr/share/icons/hicolor/32x32(hicolor-icon-theme, fedora-logos, eom), /usr/share/icons/hicolor(hicolor-icon-theme, fedora- logos), /usr/share/icons/hicolor/scalable(hicolor-icon-theme, fedora- logos, eom, hexchat) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in trojita [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2181120 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: trojita-0.4.1-2.fc21.i686.rpm trojita-0.4.1-2.fc21.src.rpm trojita.i686: W: spelling-error %description -l en_US Trojitá -> Trojan trojita.i686: W: spelling-error %description -l en_US interoperable -> inter operable, inter-operable, inoperable trojita.i686: W: no-manual-page-for-binary be.contacts trojita.i686: W: no-manual-page-for-binary trojita trojita.src: W: spelling-error %description -l en_US Trojitá -> Trojan trojita.src: W: spelling-error %description -l en_US interoperable -> inter operable, inter-operable, inoperable 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint trojita trojita.i686: W: spelling-error %description -l en_US Trojitá -> Trojan trojita.i686: W: spelling-error %description -l en_US interoperable -> inter operable, inter-operable, inoperable trojita.i686: W: no-manual-page-for-binary be.contacts trojita.i686: W: no-manual-page-for-binary trojita 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- trojita (rpmlib, GLIBC filtered): /bin/sh libQtCore.so.4 libQtGui.so.4 libQtNetwork.so.4 libQtSql.so.4 libQtWebKit.so.4 libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libtrojita_plugins.so libz.so.1 rtld(GNU_HASH) Provides -------- trojita: application() application(trojita.desktop) libtrojita_plugins.so trojita trojita(x86-32) Unversioned so-files -------------------- trojita: /usr/lib/trojita/libtrojita_plugins.so Source checksums ---------------- http://downloads.sourceforge.net/trojita/trojita-0.4.1.tar.bz2 : CHECKSUM(SHA256) this package : 68a17498e70fd66966917fe4ecb90e6fe6f36f439c714552b8a97c004fe687de CHECKSUM(SHA256) upstream package : 68a17498e70fd66966917fe4ecb90e6fe6f36f439c714552b8a97c004fe687de Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn trojita-0.4.1-2.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -------------------------------------------- Besides above issues, you have: 1. From the koji build log: -- The following features have been disabled: * WITH_HARMATTAN , Build MeeGo Harmattan version * WITH_QT5 , Build with Qt5 library * DEV_FATAL_WARNINGS , Turn build warnings into errors (developers only) * WITH_RAGEL , Build with Ragel library WITH_RAGEL option is needed for building the parser from source, right? ragel is in Fedora repo, you should use that one as BR. 2. %check section, since upstream has stated: $ ctest -j 4 --output-on-failure So I think you can use smp flags here(you can have a try) 3. Appdata file should be created. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review