https://bugzilla.redhat.com/show_bug.cgi?id=1084813 --- Comment #12 from Michael Schwendt <bugs.michael@xxxxxxx> --- fedora-review reports a couple of errors and warnings about gnubatch-1.10-4.fc20.src.rpm. Also notice the long list of W/E from rpmlint, which are included in the fedora-review report, too. > License: GPLv3 The fedora-review license check does not agree. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses > The only bit I wasn't sure what you meant was the > "Directory /usr/share/gnubatch is not included." comment. The two links I added explain it well. Your spec file %files section does not include the directories /usr/share/gnubatch /usr/share/gnubatch/help but only the contents of /usr/share/gnubatch/help: $ rpmls -p gnubatch-1.10-4.fc20.x86_64.rpm |grep ^d drwxr-xr-x /usr/share/doc/gnubatch drwxr-xr-x /usr/share/man/man1 drwxr-xr-x /usr/share/man/man3 drwxr-xr-x /usr/share/man/man5 drwxr-xr-x /usr/share/man/man8 drwxr-xr-x /var/gnubatch * The build.log reveals that Fedora's global compiler flags are not used: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags * A simple "rpmbuild --rebuild …" on Fedora 20 ends with a built failure, which could mean that possibly something is installed that's not installed the cleaner Mock buildroot: ! LaTeX Error: File `xifthen.sty' not found. Type X to quit or <RETURN> to proceed, or enter new name. (Default extension: sty) Enter file name: > /sbin/ldconfig: /lib64/libgnubatch_int.so.1 is not a symbolic link > > These really should be sym links but I can see a preserve flag to > install (aside from selinux context). Am I missing something here, > or is this expected and OK? There are multiple packaging bugs related to it: $ rpmls -p gnubatch-1.10-4.fc20.x86_64.rpm |grep lib64 -rwxr-xr-x /usr/lib64/libgnubatch_client.a -rwxr-xr-x /usr/lib64/libgnubatch_client.la -rwxr-xr-x /usr/lib64/libgnubatch_client.lai -rwxr-xr-x /usr/lib64/libgnubatch_client.so -rwxr-xr-x /usr/lib64/libgnubatch_client.so.1 -rwxr-xr-x /usr/lib64/libgnubatch_client.so.1.0.0 -rwxr-xr-x /usr/lib64/libgnubatch_curs.a -rwxr-xr-x /usr/lib64/libgnubatch_curs.la -rwxr-xr-x /usr/lib64/libgnubatch_curs.lai -rwxr-xr-x /usr/lib64/libgnubatch_curs.so -rwxr-xr-x /usr/lib64/libgnubatch_curs.so.1 -rwxr-xr-x /usr/lib64/libgnubatch_curs.so.1.0.0 -rwxr-xr-x /usr/lib64/libgnubatch_int.a -rwxr-xr-x /usr/lib64/libgnubatch_int.la -rwxr-xr-x /usr/lib64/libgnubatch_int.lai -rwxr-xr-x /usr/lib64/libgnubatch_int.so -rwxr-xr-x /usr/lib64/libgnubatch_int.so.1 -rwxr-xr-x /usr/lib64/libgnubatch_int.so.1.0.0 About the .a files (static libs) and the .la files (libtool archives): https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries About the .so files, they should be a chain of symlinks: .so -> .so.1 -> .so.1.0.0 The executable is linked with the versioned libs: $ rpm -qpR gnubatch-1.10-4.fc20.x86_64.rpm |grep gnubat config(gnubatch) = 1.10-4.fc20 libgnubatch_client.so.1()(64bit) libgnubatch_curs.so.1()(64bit) libgnubatch_int.so.1()(64bit) That means the ldconfig scriptlets are missing: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries The non-versioned .so files/symlinks need not be included in the package. https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages > install -pm 644 doc/poddoc/man/*.3 %{buildroot}/%{_mandir}/man3/ Those are about an API. Hence its manual section 3. But where is the API? No headers in the package. Did you forget to install headers into the buildroot? If so, you will also need to create a -devel subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review