https://bugzilla.redhat.com/show_bug.cgi?id=1084813 --- Comment #11 from Jon Kent <jon.kent@xxxxxxxxx> --- Hi, Again, thanks for the quick feedback. As you've probably gathered from the previous 3 entries here I've been checking this against fedora-review (must admit I'd forgotten about that tool). I've done as you've suggested, does look cleaner and I think the summary is more descriptive now. Not idea why I added those flags to configure, just paranoid I think. I also updated the description to put more detail around what gnubatch does, which I think is better than before. The only bit I wasn't sure what you meant was the "Directory /usr/share/gnubatch is not included." comment. If this refers to the perms, then I'm happy with them as they now are. If not can you please let me know. The only error I'm seeing from Fedora Reviewer is : /sbin/ldconfig: /lib64/libgnubatch_curs.so.1 is not a symbolic link /sbin/ldconfig: /lib64/libgnubatch_client.so.1 is not a symbolic link /sbin/ldconfig: /lib64/libgnubatch_int.so.1 is not a symbolic link /sbin/ldconfig: /lib64/libgnubatch_curs.so.1 is not a symbolic link /sbin/ldconfig: /lib64/libgnubatch_client.so.1 is not a symbolic link /sbin/ldconfig: /lib64/libgnubatch_int.so.1 is not a symbolic link These really should be sym links but I can see a preserve flag to install (aside from selinux context). Am I missing something here, or is this expected and OK? Spec file and src rpms updated. I had to relocate the spec file to my SpiderOak share as 'fedora reviewer' had problems downloading from github. Thanks, Jon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review