[Bug 1087536] Review Request: perl-HTML-FormFu-MultiForm - Handle multi-page/stage forms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1087536

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Ralf Corsepius from comment #2)
> - The package treats Crypt::DES as required dependency, while it actually
> doesn't use it (You seem to have commented out BR: perl(Crypt::DES) because
> of this)
> 
> I.e. this package only builds by random coincidence, because another package
> (perl-HTML-FormFu) indirectly pulls in perl-Crypt-DES. If perl-HTML-FormFu
> didn't do so, building this package would fail.
> 
> I'd recommend to patch out Crypt::DES from the source code.
>
That's interesting problem. The Crypt::CBC calls from this package do not
request Crypt::DES anywhere in the code. None CBC::Crypt->new() passes -cipher
argument. The code relays on CBC::Crypt default algorithm which is CBC::DES.

However perl-Crypt-CBC does require Crypt::DES. I would rather see
perl-Crypt-CBC run-requiring Crypt::DES to conform to Crypt::CBC documentation.

Unfortunately the perl-Crypt-CBC is in dependency cycle with perl-Crypt-DES and
Paul decided to make the dependency on Crypt::DES optional.

So I will add the dependency on Crypt::DES into perl-HTML-FormFu-MultiForm to
follow the upstream path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]