https://bugzilla.redhat.com/show_bug.cgi?id=1087536 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> --- APPROVED 2 remarks on issues, you probably are aware about: - The package treats Crypt::DES as required dependency, while it actually doesn't use it (You seem to have commented out BR: perl(Crypt::DES) because of this) I.e. this package only builds by random coincidence, because another package (perl-HTML-FormFu) indirectly pulls in perl-Crypt-DES. If perl-HTML-FormFu didn't do so, building this package would fail. I'd recommend to patch out Crypt::DES from the source code. - I am not happy with "PERL_HASH_SEED=0 make test", because it's not clear to me whether this is just an issue with the test-suite or whether this is a defect of this package in general. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review