[Bug 229826] Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826


bugzilla@xxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium




------- Additional Comments From bbbush.yuan@xxxxxxxxx  2007-04-08 21:38 EST -------
Now test2 is out.

It now uses pkg-config to configure firefox-gtkmozembed include and libs path.
Since on fedora, firefox-gtkmozembed.pc doesn't contain
-R/usr/lib/firefox-2.0.0.3/   so RPATH is not used when linking chmsee. 

Since /usr/lib/firefox-2.0.0.3/ is not in ldconfig path, the compiled chmsee
binary cannot run without setting LD_LIBRARY_PATH.

run "ldd /usr/bin/chmsee" will output
[yuan@mstar ~]$ ldd /usr/bin/chmsee |grep "not found"
       libgtkembedmoz.so => not found
       libxpcom.so => not found
       libxpcom_core.so => not found

It is suggested to make a wrapper "chmsee" to call the binary (rename it
chmsee.bin or so), then in the wrapper we can search for firefox install
directory to avoid rebuild everytime firefox has an update. I think it may
introduce security issue if anyone make another wrapper to load different
libgtkmozembed.so.

Any opinion? I can see the same thing on FE package lifera, but they use fixed
LD_LIBRARY_PATH (that is, they need to rebuild when firefox has an update).

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]