Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-brutus Alias: evolution-brutus https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-07 12:42 EST ------- Well, again I review this package (evolution-brutus) For 1.1.25.3-2 * Source0 - By the way, where is 1.1.25.3 tarball? * compilation flags - Why are fedora specific compilation flags passed _twice_ ? ----------------------------------------------------------- make[3]: Entering directory `/builddir/build/BUILD/evolution-brutus-1.1.25.3/idl_output' /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/builddir/build/BUILD/evolution-brutus-1.1.25.3/idl_output -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libIDL-2.0 -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror -Werror-implicit-function-declaration -Wundef -Wpointer-arith -Wbad-function-cast -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -std=gnu89 -D_REENTRANT -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -DG_LOG_DOMAIN=\"libBrutusSTUBS\" -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libIDL-2.0 -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror -Werror-implicit-function-declaration -Wundef -Wpointer-arith -Wbad-function-cast -Wcast-align -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -std=gnu89 -D_REENTRANT -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -MT IDistList-common.lo -MD -MP -MF .deps/IDistList-common.Tpo -c -o IDistList-common.lo IDistList-common.c mkdir .libs ----------------------------------------------------------- * pkgconfig .pc file - Well why are the seemingly-extra include options ----------------------------------------------------------- -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 ----------------------------------------------------------- in Cflags in .pc files needed, although ORBit-2.0 (therefore glib-2.0 and is required by .pc files? ----------------------------------------------------------- For upstream: * Documentation - Why are the following documents empty? AUTHORS ChangeLog NEWS -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review