https://bugzilla.redhat.com/show_bug.cgi?id=1080094 --- Comment #3 from Ralph Bean <rbean@xxxxxxxxxx> --- > 1) Either own /etc/fedmsg.d or add Requires: on package that owns that directory but I see fedmsg package should actually own it, please fix fedmsg package. fedmsg fixed in rawhide now. > 2) If this is only fedora spec then you don't need Group tag and python conditional macro definition at top of spec. Otherwise follow EPEL specific guideliens like buildroot, %clean, defattr, removal of buildroot in %install Okay -- this will be for el6, but not el5. I think that means that defining the buildroot, %clean, defattr, removal of the buildroot, etc.. all are not required. > 3) cp or install commands should follow "-p" to preserve timestamp of upstream files being copied in the system. Fixed in this release: Spec URL: http://threebean.org/rpm/SPECS/python-fedmsg-genacls.spec SRPM URL: http://threebean.org/rpm/SRPMS/python-fedmsg-genacls-0.1-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review