https://bugzilla.redhat.com/show_bug.cgi?id=1080094 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + Package built successfully in mock rawhide + rpmlint on generated rpms gave output python-fedmsg-genacls.noarch: W: spelling-error Summary(en_US) gitosis -> mitosis, halitosis python-fedmsg-genacls.noarch: W: spelling-error Summary(en_US) acls -> aces, ails, acts python-fedmsg-genacls.noarch: W: spelling-error Summary(en_US) pkgdb -> pkg db, pkg-db, pkg python-fedmsg-genacls.noarch: W: spelling-error %description -l en_US pkgdb -> pkg db, pkg-db, pkg python-fedmsg-genacls.src: W: spelling-error Summary(en_US) gitosis -> mitosis, halitosis python-fedmsg-genacls.src: W: spelling-error Summary(en_US) acls -> aces, ails, acts python-fedmsg-genacls.src: W: spelling-error Summary(en_US) pkgdb -> pkg db, pkg-db, pkg python-fedmsg-genacls.src: W: spelling-error %description -l en_US pkgdb -> pkg db, pkg-db, pkg 2 packages and 0 specfiles checked; 0 errors, 8 warnings. + Source verified with upstream as (sha256sum) srpm tarball:321d70af11cef939a6d665dd32accdec0e0efedf2c1b36723b038ddcf70c5ff4 upstream tarball:321d70af11cef939a6d665dd32accdec0e0efedf2c1b36723b038ddcf70c5ff4 + License is valid and included in LICENSE file + rest looks as per packaging guidelines Suggestions: 1) Either own /etc/fedmsg.d or add Requires: on package that owns that directory but I see fedmsg package should actually own it, please fix fedmsg package. 2) If this is only fedora spec then you don't need Group tag and python conditional macro definition at top of spec. Otherwise follow EPEL specific guideliens like buildroot, %clean, defattr, removal of buildroot in %install 3) cp or install commands should follow "-p" to preserve timestamp of upstream files being copied in the system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review