Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sakura - A terminal emulator based on GTK+ and VTE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234721 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-04-06 12:19 EST ------- Some notes: * Timestamps - Well, while the method 'INSTALL="%{__install} -p"' normally works for makefile.in generated by GNU autotools, for the types of makefiles which were created by developer by his own way (like this package), it is very rare that this method still works (and actually for this package it does not work). For the latter case, the packager has to check what are actually done on install stage and fix some files appropriately. Normally the package has to change the command like "cp" or "install" appropriately (see the lines 119-148 of mobs.mk). * Cflags - And for makefiles generated by GNU autotools, fedora specific compilation flags are normally passed correctly by %configure macro (please check what %configure actually does), however, again for the types of makefiles created by the developer's own way, passing cflags has to be done with a special care Actually ------------------------------------------ %build ./0 --prefix=/usr make %{?_smp_mflags} ------------------------------------------ does not use fedora specific compilation flags (%optflags or $RPM_BUILD_FLAGS). You have to use this flags _somehow_ * Desktop file - Be careful on the each item on desktop file (e.g. is the path for icon used correct? in the first place, does the path have to be specified by full path?) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review