Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sakura - A terminal emulator based on GTK+ and VTE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234721 ------- Additional Comments From lxtnow@xxxxxxxxx 2007-04-06 10:48 EST ------- Well, You should add flags INSTALL="install -p" to your make install to keep timestamp on files, such as doc files, *.png files (which is included including in this package). ------ .desktop file ------ ** category: Application and X-fedora is deprecated and SHOULD be remove. can be fix by adding "-remove-category=" option ** .desktop file : no correct permission -> 0664 [SmootherFrOgZ@Helzeilerd ~]$ ll rpmbuild/SOURCES/sakura.desktop -rw-rw-r-- 1 SmootherFrOg lxtnow 271 Apr 6 09:47 rpmbuild/SOURCES/sakura.desktop can be fix by adding -mode 0644 option from desktop-file-install. ** scriptlets: %post update-desktop-database &> /dev/null ||: %postun update-desktop-database &> /dev/null ||: The use of above is only require when the desktop entry have a mime type key. and isn't the case. This scriptlet can be remove. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review