[Bug 1069257] Review Request: fparser - Function parser library for C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1069257



--- Comment #33 from Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> ---
(In reply to Michael Schwendt from comment #32)
> Anyway, if you say MPFR/GMP is not needed, only the three headers ought to
> be dropped. Shipping internal headers is not a great idea. Eventually
> somebody would start including them.

I'm not saying it isn't needed, but it isn't essential. I don't think it would
be a good idea to build the library with MPFR/GMP support without adding
dependencies to these libraries, so I guess not supporting MPFR/GMP altogether
is the best solution (as we discussed earlier). If somebody needs MPFR/GMP
support, they can still use fparser as copylib.

That said, I removed the internal header files from the package. I also had
another look at the debian package. They use some macros in configure.ac which
don't seem to have any effect (because they define something which isn't
used/checked by fparser). Other than that, it is similar to ours (yours).

I moved the autoreconf call to %prep.


Thanks for your help!


SPEC: http://thofmann.fedorapeople.org/fparser.spec
SRPM http://thofmann.fedorapeople.org/fparser-4.5.1-7.fc20.src.rpm
patch: http://thofmann.fedorapeople.org/fparser.autotools.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]