[Bug 1077762] Review Request: rubygem-bcrypt - Wrapper around bcrypt() password hashing algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1077762



--- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Wrong rename obsoletes
  - They should be:

    Provides: rubygem(brypt-ruby) = %{version}
    Provides: rubygem-brypt-ruby = %{version}-%{release}
    Obsoletes: rubygem-brypt-ruby <= 3.1.2-1

  - Please note that it is not good idea to obsolete virtual provide. You
should
    obsolete the package.
  - See the [1] for more info.

* Add -doc subpackage
  - Please consider adding -doc subpackage and move non-essential stuff there.


[1]
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]