https://bugzilla.redhat.com/show_bug.cgi?id=1074242 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On|1077956 | Flags|fedora-review? |fedora-review+ --- Comment #6 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to David Dick from comment #5) > TODO: Add the missing perl(Config) BR, Makefile.PL:6 > > Done. Check. > TODO: Substitute PERL_INSTALL_ROOT with DESTDIR > > Done. Check. > TIP: How about packaging the `eg' directory, too? > > The eg directory contains a dependency on perl-Image-SubImageFind. I have > prepared this package at > https://bugzilla.redhat.com/show_bug.cgi?id=1077956, made it ready for > review, and marked it as blocking this review. You generally don't have to care about dependencies of scripts packages in the docs. Of course it's nice when you can actually run them on Fedora, they're still just examples/documentation. I've removed the blocker. > FIX: Given the copyright headers in all the source files, I think the > License tag should be corrected to `GPLv2+'. > > Done Check. > Also, is libXi-devel really required? I don't see its headers used anywhere. > > This is where X11/extensions/XInput.h exists in EL6. Note the successful > koji build at > > http://koji.fedoraproject.org/koji/taskinfo?taskID=6648210 > > vs the one with libXi-devel not present at > > http://koji.fedoraproject.org/koji/taskinfo?taskID=6648242 > > I have added a comment explaining this into the spec file Oh yes, I grep'd the sources for XInput but couldn't see it used anywhere. Apparently it's pulled in via XTest.h. I think libXtst-devel should require that. Feel free to report a bug :) Of course we'll need the dependency for now... I'm approving the package now. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1077956 [Bug 1077956] Review Request: perl-Image-SubImageFind - Perl extension for locating a sub-image within an image -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review