[Bug 1074242] Review Request: perl-X11-GUITest - Provides GUI testing/interaction routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1074242



--- Comment #5 from David Dick <ddick@xxxxxxxx> ---
TODO: Add the missing perl(Config) BR, Makefile.PL:6

Done.

TODO: Substitute PERL_INSTALL_ROOT with DESTDIR

Done.

TIP: How about packaging the `eg' directory, too?

The eg directory contains a dependency on perl-Image-SubImageFind.  I have
prepared this package at https://bugzilla.redhat.com/show_bug.cgi?id=1077956,
made it ready for review, and marked it as blocking this review. 

FIX: Given the copyright headers in all the source files, I think the License
tag should be corrected to `GPLv2+'.

Done

Also, is libXi-devel really required?  I don't see its headers used anywhere.

This is where X11/extensions/XInput.h exists in EL6.  Note the successful koji
build at 

http://koji.fedoraproject.org/koji/taskinfo?taskID=6648210

vs the one with libXi-devel not present at

http://koji.fedoraproject.org/koji/taskinfo?taskID=6648242

I have added a comment explaining this into the spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]