https://bugzilla.redhat.com/show_bug.cgi?id=1065685 --- Comment #7 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Thanks very much for the review! (In reply to Achilleas Pipinellis from comment #2) > - Use `cp -pa` to preserve timestamps, currently you do `cp -a`. It's my understanding that "-a" implies "-p". > - rpmlint complains about: `No known owner of > /usr/share/gems/gems/unicorn-4.8.2/bin, /usr/lib64/gems/ruby/unicorn-4.8.2`. Good catch, thanks. I've gone with "%{gem_instdir}/bin" in -3. I've also removed the asterisk after gem_extdir_mri, so the package ships /usr/lib64/gems/ruby/unicorn-4.8.2 now. > - You don't exclude %{gem_cache}. Good catch, thanks. Fixed in -3. > - rpmlint complains with `W: no-soname > /usr/lib64/gems/ruby/unicorn-4.8.2/lib/unicorn_http.so`. I have no idea what > this means and `rpmlint -I` doesn't give any info. Safe to ignore? I've seen this on all the C-based Ruby extensions, so I think it's safe to ignore. > - Minor but fixable :) `W: mixed-use-of-spaces-and-tabs (spaces: line 4, > tab: line 97)` Good catch, thanks. I've replaced the tabs with spaces. Fixed in -3. > - E: specfile-error -e:1:in `<main>': Use RbConfig instead of obsolete and > deprecated Config. Epel6 uses ruby1.8 which I assume uses Config so it's > safe to ignore? IMHO it's ok to ignore this since that macro only gets used on EL6. Here is the new version of rubygem-unicorn: Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-unicorn.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-unicorn-4.8.2-3.fc21.src.rpm Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-unicorn.git/commit/?id=fe2d3423797a54250ed065b1870adb8e585693d7 F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6631139 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review