https://bugzilla.redhat.com/show_bug.cgi?id=1056555 --- Comment #4 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> --- Hello Saggi, I couldn't see in my previous review but I do believe your package should be renamed to python-ioprocess [1] since you provide a python binding for the /usr/libexec/ioprocess right? Other option: Split your package into two. - ioprocess which contains the libexec/ioprocess binary and docs. - python-ioprocess which is the module to access the ioprocess [1] Almost forgot: Rename the deprecated macro https://fedoraproject.org/wiki/Packaging:Python#Macros " The unversioned macros, %{__python}, %{python_sitelib}, and %{python_sitearch} are deprecated. You should use %{__python2}, %{python2_sitelib}, and %{python2_sitearch} to explicitly reference the python2 interpreter instead. This is future proofing for the time when things will be switched over to python3 by default instead of python2. " [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 After this review, your package seems good to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review