[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1063038



--- Comment #3 from Mo Morsi <mmorsi@xxxxxxxxxx> ---
Hey Nitesh some more comments:

- Please rename the spec to 'rubygem-cookiejar.spec' so fedora-review will pick
it up (srry for any confusion about this before)

- Please bump the release up top (the next on should be 3)

- Similarly please cleanup the changelog at the bottom, you should have an
entry for each release w/ comments. The list should be in reverse chronological
order, eg newest first to oldest last

- The rspec command in the %check section should be "rspec -Ilib spec"

- contributors.json should be rm'd or excluded

- The "%{gem_instdir}/spec/*" under the files list should be replaced with
"%doc %{gem_instdir}/spec/"

- %{gem_cache} should be %exclude'd

- the LICENSE file should be part of the main package and marked as %doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]