[Bug 1062920] Review Request: rubygem-amq-protocol - AMQP 0.9.1 encoder & decoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1062920



--- Comment #8 from Mo Morsi <mmorsi@xxxxxxxxxx> ---
Hey Nitesh, just getting back to this. Some more feedback.

- You added a new changelog entry for the release but didn't bump the release
near the top. When you do so the SRPM that will be generated will be named
"rubygem-amq-protocol-1.9.2-2.srpm"

- In the "%files doc" list there should be list line "%{gem_instdir}/spec/"
instead of "%{gem_instdir}/spec/*". The former includes the directory and all
files in it, the later just includes all files in it

- "Updated as per the comments" in your changelog entry is a bit ambiguous for
future contributors / maintainers. Perhaps some like "updated from Fedora
review feedback" would be more direct (people can search bugzilla from there)

Make sure to bump the release to '3' and add a new changelog entry after the
above changes. Also like Achilleas mentioned, the links to the
'rubygem-amq-protocol.spec' and 'rubygem-amq-protocol-1.9.2-3.sprm' files
should be in the comment so fedora-review will pick them up

https://fedorahosted.org/FedoraReview/

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]