https://bugzilla.redhat.com/show_bug.cgi?id=1060438 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |crobinso@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Cole Robinson <crobinso@xxxxxxxxxx> --- fedora-review doesn't flag anything major, neither does manual inspection. Few tidbits: - https://fedoraproject.org/wiki/Packaging:Python#Macros: suggests adding a python2_sitearch definition. probably doesn't affect this package but I'd recommend following the docs for consistency - URL and Source aren't column aligned like the rest of the fields - tarball has src/pycalendar/tests but its unclear how they are expected to be invoked. might want to consider figuring it out and running them in a %check section But none of those are blocking issues IMO, so setting fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review