https://bugzilla.redhat.com/show_bug.cgi?id=1069257 --- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> --- > License: LGPLv3 That's what some of the source file headers say. But both the LGPL and GPL files are included: | %files | %doc docs/gpl.txt docs/lgpl.txt The spec file doesn't comment on that. What's the full story here? Including the GPLv3 with the package only adds confusion, IMO. > %package devel > … > Requires: %{name} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > %package devel > … > Requires: cmake, mpfr-devel, gpm-devel It's a good habit to add comments to explicit dependencies. Here the dependency on "cmake" raises the question why it has been added? Not everyone uses CMake. If the dep has been added only for directory ownership, prefer: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function > %install > rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > %files devel > … > %{_libdir}/cmake/%{name}-%{version}/* This would mean that the directory %{_libdir}/cmake/%{name}-%{version} is not included (aka being an "unowned" directory issue): https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories > -shared -Wl,-soname,libfparser4.5.1.so.4.5.1 -o libfparser4.5.1.so.4.5.1 Uh oh! That's a very fragile SONAME, which will require rebuilds of dependencies for all minor version updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review