https://bugzilla.redhat.com/show_bug.cgi?id=1065306 --- Comment #7 from Leon Weber <leon@xxxxxxxxxxxx> --- Thanks for taking a look at the package, Christopher. (In reply to Christopher Meng from comment #6) > 2. ${RPM_BUILD_ROOT} and $RPM_BUILD_ROOT are presented, please eithor use > $RPM_BUILD_ROOT or %{buildroot} (If you enjoy brackets) Whoops :) > 3. Icon=gnome-lockscreen > > In order to avoid conflicts in the future, please rename your icon. I was actually hoping to reuse gnome’s lockscreen icon, but now I’ve decided to create an extra pyxtrlock icon for Fedora. I might also ship it upstream at some point, if I decide to ship the .desktop file as well. > 4. Do you think this package needs an egg for import? :) Good catch. > 5. Please add license header for: > > Unknown or generated > -------------------- > pyxtrlock-0.2/lib/X.py > pyxtrlock-0.2/lib/__init__.py > pyxtrlock-0.2/lib/utils.py > pyxtrlock-0.2/lib/xcb.py > pyxtrlock-0.2/make_default_lock.py > pyxtrlock-0.2/setup.py > pyxtrlock-0.2/tools/make_lock.py > pyxtrlock-0.2/tools/repickle.py Is this really necessary? There’s the COPYING file explicitly stating the license, and I wouldn’t like to divert from upstream here. I might consider adding the headers upstream, but that wouldn’t be before the next release. I’ve fixed the rest for now: Spec URL: http://feynman.q-ix.net/rpm/pyxtrlock.spec SRPM URL: http://feynman.q-ix.net/rpm/pyxtrlock-0.2-4.fc19.src.rpm %changelog * Thu Feb 20 2014 Leon Weber <leon@xxxxxxxxxxxx> - 0.2-4 - Add note justifying explicit lib dependencies - Use buildroot macro consistently - Ship pyxtrlock icon - Use mkdir -p without macro - Remove egg file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review