https://bugzilla.redhat.com/show_bug.cgi?id=1060386 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |pandorafms_agent_unix - |pandorafms-agent - Pandora |Pandora FMS Linux agent. |FMS Linux agent. Alias| |pandorafms-agent --- Comment #7 from Christopher Meng <cickumqt@xxxxxxxxx> --- Ugly spec. 1. Remove this: # # spec file for package pandorafms-agent # # Pandora FMS Linux Agent # Copyright (c) 2014 Sancho Lerena # Licensed under GPL2 terms. # Please send bugfixes or comments to slerena@xxx Your email will be leaked to public for spammer. 2. %define name pandorafms-agent %define version 5.0 %define release 140201.sp3 Please use proper tag, no need to define a macro to finish that. 3. Remove these: Vendor: ArticaST <http://www.artica.es> Group: System/Monitoring Packager: Sancho Lerena <slerena@xxxxxxx> Prefix: /usr/share BuildRoot: %{_tmppath}/%{name}-%{version}-buildroot For this one /usr/share, please rpm -E %{_datadir} 4. rm -rf $RPM_BUILD_ROOT is not needed in %prep and %install 5. These are not done by command, should be done by RPM: # Checking old config file (if exists) if [ -f /etc/pandora/pandora_agent.conf ] ; then mv /etc/pandora/pandora_agent.conf /etc/pandora/pandora_agent.conf.backup fi cp -aRf $RPM_BUILD_ROOT%{prefix}/pandora_agent/Linux/pandora_agent.conf $RPM_BUILD_ROOT/usr/share/pandora_agent/pandora_agent.conf.rpmnew if [ -f $RPM_BUILD_ROOT%{prefix}/pandora_agent/pandora_agent.spec ] ; then rm $RPM_BUILD_ROOT%{prefix}/pandora_agent/pandora_agent.spec fi So remove them. 6. No %clean section please. 7. %pre is not fine: https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation 8. Please learn how to write changelog: * Sat Feb 01 2014 - slerena@xxxxx - First version, after re-re-re-reading the fedora contributor guidelines :) Take a look at existing one: http://pkgs.fedoraproject.org/cgit/nagios.git/tree/nagios.spec God, totally a mess, please clean above at first, then step forward. I can help you, but don't be hasty. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review