https://bugzilla.redhat.com/show_bug.cgi?id=1067041 --- Comment #4 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Hi Cole, Thanks for your comments. (In reply to Cole Robinson from comment #3) > > Besides the noted rpmlint spelling errors and fsf address, there's also this > minor one: > > autodocksuite.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: > line 1) > > In my .vimrc, I have: set listchars=tab:>. which shows hard tabs as > visible, but that's totally up to you. I'd recommend being consistent in the > spec at least. Fixed it. Actually, vimrc is a good suggestion. I will add it. > > Couple other points: > > - I don't think triggering ldconfig is required, the package isn't > installing any shared libraries. Done! > > - autodoc/COPYING is duplicated between the packages. Just stick it in the > base package, since -doc requires the base package. I'd also stick the > README in the -doc package but it's up to you. Done! README in -doc would be more appropriate. > > - In %build you have: > > export CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" > > Does that make a difference? The %configure macro should do that for you. > Fixed. That was from a older spec file. Sorry. :) New SPEC URL: http://nonamedotc.fedorapeople.org/pkgreview/autodocksuite/autodocksuite.spec New SRPM URL: http://nonamedotc.fedorapeople.org/pkgreview/autodocksuite/autodocksuite-4.2.5.1-4.fc20.src.rpm My fedora-review on updated files (sorry, I did not do the [x] marks this time) - http://nonamedotc.fedorapeople.org/pkgreview/autodocksuite/review.txt The older review.txt is here - http://nonamedotc.fedorapeople.org/pkgreview/autodocksuite/ver2/review.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review