https://bugzilla.redhat.com/show_bug.cgi?id=1067041 --- Comment #3 from Cole Robinson <crobinso@xxxxxxxxxx> --- The version 4.2.5.1 is fine, it comes from upstream and RPM can handle it for comparisons. Besides the noted rpmlint spelling errors and fsf address, there's also this minor one: autodocksuite.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 1) In my .vimrc, I have: set listchars=tab:>. which shows hard tabs as visible, but that's totally up to you. I'd recommend being consistent in the spec at least. Couple other points: - I don't think triggering ldconfig is required, the package isn't installing any shared libraries. - autodoc/COPYING is duplicated between the packages. Just stick it in the base package, since -doc requires the base package. I'd also stick the README in the -doc package but it's up to you. - In %build you have: export CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" Does that make a difference? The %configure macro should do that for you. FYI I'm offline till Monday, sorry for bad timing. I'll follow up ASAP when I'm back -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review