https://bugzilla.redhat.com/show_bug.cgi?id=1054933 --- Comment #4 from Mihkel Vain <turakas@xxxxxxxxx> --- Spec URL: http://mihkel.fedorapeople.org/SPECS/esteidcerts.spec SRPM URL: http://mihkel.fedorapeople.org/SRPMS/esteidcerts-3.8.0.9128-1.fc20.src.rpm Koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=6540301 Hi. Thanks for you time and review. I hope I got everything sorted out the way you suggested. (In reply to Rex Dieter from comment #3) > 1. SHOULD remove deprecated .spec items > Group: tags, %defattr I remove Group lines and %defattr lines I'll do the same for other spec files also, but not today. > 2. -devel subpkg name SHOULD be named something else > This does seem really a Development package in the > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Devel_Packages > sense to me. I'd suggest naming it something else, like -test -test it is > 3. MUST fix directory ownership > Nothing owns > %{_datadir}/esteid > I'd suggest adding to base pkg: > %dir %{_datadir}/esteid > > and -devel (or whatever it ends up called), misses anything owning parent > dirs: > %{_datadir}/esteid > %{_datadir}/esteid/certs > I'd suggest adding a dependency on the base pkg: > Requires: %{name} = %{version}-%{release} > or add here: > %dir %{_datadir}/esteid > %dir %{_datadir}/esteid/certs > I added %dir %{_datadir}/esteid to %files section and a Requires: %{name} = %{version}-%{release} line > > 4. licensing cannot be verified. the source archive doesn't seem to > mention licensing anywhere. where do you get > License: LGPLv2 > from? My mistake. According to esteidcerts.spec file in source tarball, these certs are public domain. Although they should include a LICENSE file in tarball. I'll mention that to upstream when (if) I'll finish packaging these packages and then they probably include that file in next release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review