https://bugzilla.redhat.com/show_bug.cgi?id=1054933 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Some initial comments: rpmlint is clean: $ rpmlint *.rpm */*.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings sources verified: 92b79074e4f6db85453f561f9d9ab35f esteidcerts-3.8.0.9128.tar.gz 1. SHOULD remove deprecated .spec items Group: tags, %defattr these are deprecated and unused, see also: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag and https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_Permissions respectively 2. -devel subpkg name SHOULD be named something else This does seem really a Development package in the https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Devel_Packages sense to me. I'd suggest naming it something else, like -test 3. MUST fix directory ownership Nothing owns %{_datadir}/esteid I'd suggest adding to base pkg: %dir %{_datadir}/esteid and -devel (or whatever it ends up called), misses anything owning parent dirs: %{_datadir}/esteid %{_datadir}/esteid/certs I'd suggest adding a dependency on the base pkg: Requires: %{name} = %{version}-%{release} or add here: %dir %{_datadir}/esteid %dir %{_datadir}/esteid/certs See also: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership 4. licensing cannot be verified. the source archive doesn't seem to mention licensing anywhere. where do you get License: LGPLv2 from? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review