[Bug 1055837] Review Request: simbody - Multi-body Physics API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1055837



--- Comment #3 from Rich Mattes <richmattes@xxxxxxxxx> ---
Thanks Kenjiro and Michael.

I'm not sure that the make command for all the doxygen targets is necessary,
but it doesn't hurt so I added it.

I don't know where the Group tag came from, I think maybe rpmdev-newspec put it
there or I copied it from an older spec.  Either way, I've just removed it for
Fedora.

The CMake requirement was just for directory, it is still possible to use the
-devel package without CMake.  I didn't know about that guideline, thanks for
pointing it out.  I've made the simbody-devel package own datadir/cmake as per
the guidlines.

You're also right about the doc subpackage.  I made it noarch.

Finally, I fixed rpmlint warnings about the unused shared lib dependencies by
adding -Wl,--as-needed to the package's link flags.  I also re-arranged the
CMake flags so that the "sse2" instruction option is only passed in the x86_64
case, and updated to the latest upstream release.

Updated packages at:
Spec URL: http://rmattes.fedorapeople.org/RPMS/simbody/simbody.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/simbody/simbody-3.3.1-1.fc20.src.rpm

rpmlint:
$ rpmlint ./simbody.spec ../RPMS/x86_64/simbody*3.3.1*
../RPMS/noarch/simbody*3.3.1*
simbody.x86_64: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti
simbody.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
simbody.x86_64: W: spelling-error %description -l en_US neuro -> euro, neuron,
negro
simbody.x86_64: W: shared-lib-calls-exit /usr/lib64/libSimTKmath.so.3.3
exit@GLIBC_2.2.5
simbody.x86_64: W: no-manual-page-for-binary VisualizerGUI
simbody-devel.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 6 warnings.


scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6528496

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]