[Bug 1055837] Review Request: simbody - Multi-body Physics API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1055837



--- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> (This is not official review)

All publicly posted reviews are official. It's just that for approval there are
special requirements (such as becoming the reviewer to take the ticket, or
being a packagersponsor for new contributors).


> [2] Result of $ fedora-review -b 1055837 

Note that it would have been interesting, if you had filled in all the '[ ]'
fields, following the instructions at the top of fedora-review output.


Just a look at the spec file:

> Name:		simbody
> Group:		Development/Libraries

The Group tag for runtime libraries is "System Environment/Libraries" for many
years.

Alternatively, especially for modern releases of Fedora, the tag can be
omitted:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag


> %package        devel
> # For datadir/cmake/Modules
> Requires:	cmake

Is that a strict requirement? As in "it's close to impossible to use the -devel
package without CMake"? Else:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function


> %package	doc

It could be made "BuildArch: noarch", couldn't it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]