https://bugzilla.redhat.com/show_bug.cgi?id=1060440 --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. I saw init file, so it meant to be that systemd support need to be added also. 2. %postun if [ "$1" -ge "1" ] ; then /sbin/service <script> condrestart >/dev/null 2>&1 || : fi What's the content between <>? 3. We don't need this %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} 4. python2-devel is needed instead of python-devel, %{python_sitearch} --> %{python2_sitearch}, %{__python} --> %{__python2}, on el6 if you don't want to maintain a separate spec you can overwrite the macro by: %if 0%{?rhel} && 0%{?rhel} < 7 %{!?__python2: %global __python2 /usr/bin/python2} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif 5. No rm -rf $RPM_BUILD_ROOT in %install 6. Forgot to own this dir: %{_sysconfdir}/caldavd/ of %config(noreplace) %{_sysconfdir}/caldavd/caldavd.plist -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review