https://bugzilla.redhat.com/show_bug.cgi?id=989847 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- $ rpmlint mingw-plibc.spec mingw-plibc.spec:13: W: macro-in-comment %{snapshot_rev} mingw-plibc.spec: W: invalid-url Source0: plibc-code-147-trunk.zip 0 packages and 1 specfiles checked; 0 errors, 2 warnings. $ rpmlint mingw-plibc-0.1.7-0.2.20130812svn147.fc20.src.rpm mingw-plibc.src: W: spelling-error %description -l en_US libc -> lib, lib c mingw-plibc.src:13: W: macro-in-comment %{snapshot_rev} mingw-plibc.src: W: invalid-url Source0: plibc-code-147-trunk.zip 1 packages and 0 specfiles checked; 0 errors, 3 warnings $ rpmlint mingw32-plibc-0.1.7-0.2.20130812svn147.fc20.noarch.rpm mingw64-plibc-0.1.7-0.2.20130812svn147.fc20.noarch.rpm mingw32-plibc.noarch: W: spelling-error %description -l en_US libc -> lib, lib c mingw32-plibc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-plibc/COPYING mingw32-plibc.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-plibc/COPYING mingw32-plibc.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/plibc.h mingw32-plibc.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/langinfo.h mingw64-plibc.noarch: W: spelling-error %description -l en_US libc -> lib, lib c mingw64-plibc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-plibc/COPYING mingw64-plibc.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-plibc/COPYING mingw64-plibc.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/plibc.h mingw64-plibc.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/langinfo.h 2 packages and 0 specfiles checked; 6 errors, 4 warnings. $ rpm --query --requires mingw32-plibc rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32(advapi32.dll) mingw32(comdlg32.dll) mingw32-crt mingw32-filesystem >= 95 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libintl-8.dll) mingw32(msvcrt.dll) mingw32(ole32.dll) mingw32(shell32.dll) mingw32(user32.dll) mingw32(ws2_32.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-plibc rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64(advapi32.dll) mingw64(comdlg32.dll) mingw64-crt mingw64-filesystem >= 95 mingw64(kernel32.dll) mingw64(libintl-8.dll) mingw64(msvcrt.dll) mingw64(ole32.dll) mingw64(shell32.dll) mingw64(user32.dll) mingw64(ws2_32.dll) rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw32-libmicrohttpd-static mingw32-libmicrohttpd = 0.9.33-1.fc20 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-libmicrohttpd-static mingw64-libmicrohttpd = 0.9.33-1.fc20 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-plibc mingw32-plibc = 0.1.7-0.2.20130812svn147.fc20 mingw32(libplibc-1.dll) $ rpm --query --provides mingw64-plibc mingw64-plibc = 0.1.7-0.2.20130812svn147.fc20 mingw64(libplibc-1.dll) + OK ! Needs to be looked into / Not applicable [!] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [!] Requires of the binary mingw32 and mingw64 packages are equal The invalid-url rpmlint warning can be ignored as you're using a SVN checkout The spelling rpmlint warnings can also be ignored The wrong-file-end-of-line-encoding and incorrect-fsf-address rpmlint warnings should be reported upstream, but they're not blocking for this review The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64 package doesn't. I've also seen this on various other packages so we can ignore this for now ================================================= The package mingw-plibc is APPROVED by epienbro ================================================= -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review