[Bug 989850] Review Request: mingw-libmicrohttpd - MinGW package for libmicrohttpd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=989850

Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> ---
$ rpmlint mingw-libmicrohttpd.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw-libmicrohttpd-0.9.33-1.fc20.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw32-libmicrohttpd-0.9.33-1.fc20.noarch.rpm
mingw32-libmicrohttpd-static-0.9.33-1.fc20.noarch.rpm
mingw64-libmicrohttpd-0.9.33-1.fc20.noarch.rpm
mingw64-libmicrohttpd-static-0.9.33-1.fc20.noarch.rpm 
mingw32-libmicrohttpd-static.noarch: W: no-documentation
mingw64-libmicrohttpd-static.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.


$ rpm --query --requires mingw32-libmicrohttpd
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 95
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libgcrypt-11.dll)
mingw32(libgnutls-28.dll)
mingw32(libplibc-1.dll)
mingw32(libwinpthread-1.dll)
mingw32(msvcrt.dll)
mingw32-pkg-config
mingw32(ws2_32.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-libmicrohttpd
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 95
mingw64(kernel32.dll)
mingw64(libgcrypt-11.dll)
mingw64(libgnutls-28.dll)
mingw64(libplibc-1.dll)
mingw64(libwinpthread-1.dll)
mingw64(msvcrt.dll)
mingw64-pkg-config
mingw64(ws2_32.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw32-libmicrohttpd-static
mingw32-libmicrohttpd = 0.9.33-1.fc20
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-libmicrohttpd-static
mingw64-libmicrohttpd = 0.9.33-1.fc20
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1


$ rpm --query --provides mingw32-libmicrohttpd
mingw32-libmicrohttpd = 0.9.33-1.fc20
mingw32(libmicrohttpd-10.dll)

$ rpm --query --provides mingw64-libmicrohttpd
mingw64-libmicrohttpd = 0.9.33-1.fc20
mingw64(libmicrohttpd-10.dll)

$ rpm --query --provides mingw32-libmicrohttpd-static
mingw32-libmicrohttpd-static = 0.9.33-1.fc20

$ rpm --query --provides mingw64-libmicrohttpd-static
mingw64-libmicrohttpd-static = 0.9.33-1.fc20


$ wget --quiet http://ftp.gnu.org/gnu/libmicrohttpd/libmicrohttpd-0.9.33.tar.gz
-O - | md5sum
013b10f9de1cda5448b29c81305354a3  -
$ md5sum libmicrohttpd-0.9.33.tar.gz 
013b10f9de1cda5448b29c81305354a3  libmicrohttpd-0.9.33.tar.gz


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
    to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[!] Requires of the binary mingw32 and mingw64 packages are equal


The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64
package doesn't. I've also seen this on various other packages so we can
ignore this for now

The BuildRequires: mingw32-filesystem mingw64-filesystem should be versioned
(to >= 95).
Please fix this before importing this package in Fedora


=========================================================
 The package mingw-libmicrohttpd is APPROVED by epienbro
=========================================================

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]