https://bugzilla.redhat.com/show_bug.cgi?id=825409 --- Comment #28 from Scott K Logan <logans@xxxxxxxxxxx> --- Thanks for updating the package, Rich. Great progress! I've got a couple more notes: A) Having the gazebo_player library unversioned is definitely a step in the right direction. This way it matches the existing player plugins. However, the real problem is that gazebo-config.cmake is still looking for it, and fails to build when it can't find it in /usr/lib64. The only logical course of action (in my mind) is to add %{_libdir}/player to the library search path at cmake/gazebo-config.cmake.in:18 AND make gazebo-devel depend on gazebo-playerplugin (so the library is installed). The only alternative is to remove gazebo_player from gazebo-config.cmake after it is generated. B) I've had trouble viewing the gazebo icon in gnome on some machines because it is not square. I've narrowed it down to machines that have the AMD proprietary driver installed on them. They simply do not display an icon if it is not square. To solve this, I've changed the svg file to make it square, and shifted the viewport to the original size. This seems to be viewable on all of the systems I've tried. To do this easily, I've written the following sed command to be used instead of the cp command in the %install section of the spec: sed 'N; s/width="\([0-9\.]*\)"\n\([ ]*\)height="\([0-9\.]*\)"/width="\3"\n\2height="\3"\n\2viewBox="0 0 \1 \3"/' \ gazebo/gui/images/gazebo.svg > %{buildroot}%{_datadir}/icons/hicolor/scalable/apps/%{name}.svg This should continue to function even if the svg image's dimensions change upstream, and will ensure that all machines can see the icon as intended. Thanks for your hard work getting this massive package working! --scott -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review