[Bug 884759] Review Request: toilet - colorful ASCII art generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=884759



--- Comment #16 from Zuzana <zidkova.zuzana@xxxxxxxxx> ---
(In reply to Christopher Meng from comment #15)


> 1. The latest version is 0.3. Please read comment 3 carefully.

Toilet 0.3 requires libcaca library at least in version 0.99.beta18 but it is
not available in any Fedora. Therefore such update is not possible and we need
to stick to 0.2:

configure: error: you need libcaca version 0.99.beta18 or later
error: Bad exit status from /var/tmp/rpm-tmp.G43QWj (%build)


> 2. Remove rm -rf $RPM_BUILD_ROOT in %install, not needed anymore nowadays.

Done, thanks. 

> 3. And, you didn't bump the changelog for each change, please do from now on.

Changelog entry added and release bumped.

> 4. Michael pointed out the poor summary in the past, and I think the title
> of this bug contains a good example, however the one you currently use is
> poor still:
> 5. Summary: Display large colorful characters is still not perfect.

Summary is now changed to "Colorful ASCII Art Generator".

> -----------------------
> 
> Advice: Since you still need a sponsor, please send a self introduction
> email to @devel list to introduce yourself.
> 
> To assignee: Please keep review flag cohering with the assignee, please re
> assign this to yourself if you still have interests.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]