[Bug 884759] Review Request: toilet - colorful ASCII art generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=884759

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|pknirsch@xxxxxxxxxx         |nobody@xxxxxxxxxxxxxxxxx
              Flags|fedora-review?              |



--- Comment #15 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to Zuzana from comment #14)
> Packages updated. Thank you for advice and sorry for the delay. 

No problem. Issues:

1. The latest version is 0.3. Please read comment 3 carefully.

2. Remove rm -rf $RPM_BUILD_ROOT in %install, not needed anymore nowadays.

3. And, you didn't bump the changelog for each change, please do from now on.

4. Michael pointed out the poor summary in the past, and I think the title of
this bug contains a good example, however the one you currently use is poor
still:

5. Summary: Display large colorful characters is still not perfect.

--------One day--------

Noob A: Is it a library?
Noob B: Maybe, but I think it's a utility, bash script?
Noob C: Why bash script? Can be javascript as well!
Noob D: W** is the "large colorful"?
Noob E: Dunno.

Then they go away.

-----------------------

Advice: Since you still need a sponsor, please send a self introduction email
to @devel list to introduce yourself.

To assignee: Please keep review flag cohering with the assignee, please re
assign this to yourself if you still have interests.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]