[Bug 1032425] Review Request: perl-XML-Parser-Lite - Lightweight regexp-based XML parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032425



--- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

--- perl-XML-Parser-Lite.spec.old       2013-11-20 08:43:11.000000000 +0100
+++ perl-XML-Parser-Lite.spec   2014-02-05 16:49:07.000000000 +0100
@@ -1,8 +1,8 @@
 Name:           perl-XML-Parser-Lite
-Version:        0.717
+Version:        0.719
 Release:        1%{?dist}
 Summary:        Lightweight regexp-based XML parser
-License:        GPL+ or Artistic
+License:        (GPL+ or Artistic) and REX
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/XML-Parser-Lite/
 Source0:       
http://www.cpan.org/authors/id/P/PH/PHRED/XML-Parser-Lite-%{version}.tar.gz
@@ -15,13 +15,14 @@
 BuildRequires:  perl(SOAP::Test)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(Test)
+BuildRequires:  perl(Test::More)
 BuildRequires:  perl(warnings)
 BuildRequires:  perl(XMLRPC::Lite)
 BuildRequires:  perl(XMLRPC::Test)
 Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo
$version))

 %description
-This Perl module implements an XML parser with a interface similar to
+This Perl module implements an XML parser with an interface similar to
 XML::Parser.  Though not all callbacks are supported, you should be able to
 use it in the same way you use XML::Parser.

@@ -46,5 +47,8 @@
 %{_mandir}/man3/*

 %changelog
+* Wed Feb 05 2014 Petr Šabata <contyk@xxxxxxxxxx> - 0.719-1
+- 0.719 bump
+
 * Wed Nov 20 2013 Petr Šabata <contyk@xxxxxxxxxx> - 0.717-1
 - Specfile autogenerated by cpanspec 1.78.

> TODO: Fix grammar mistake `a interface'.
Ok.

> FIX: There is another license at lib/XML/Parser/Lite.pm:63
-License:        GPL+ or Artistic
+License:        (GPL+ or Artistic) and REX
Ok.

> FIX: The lib/XML/Parser/Lite.pm contains copyright for foreign module
I've raised an issue with upstream about the module header but I don't think
this is a blocker as there's a correct copyright notice in the POD.
Ok.

> http://psabata.fedorapeople.org/pkgs/perl-XML-Parser-Lite/perl-XML-Parser-Lite-0.719-1.fc19.src.rpm
There is no document. I will suppose
<http://psabata.fedorapeople.org/pkgs/perl-XML-Parser-Lite/perl-XML-Parser-Lite-0.719-1.fc20.src.rpm>.

URL and Source0 are usable. Ok.
Source archive is original (SHA-256:
7c8c8a42bd7e6b64cd92d445132f57a6db23952741796e4764b59cb9c9011b05). Ok.
URL and Source

SOAP::Test is optional for test. Ok.
XMLRPC::Lite is optional for test. Ok.
License is Ok.

FIX: Tests do not pass in F21
(http://koji.fedoraproject.org/koji/taskinfo?taskID=6499398). See
<https://rt.cpan.org/Public/Bug/Display.html?id=91434> for bug report.

Because the package does not build, I cannot finish the review. Please fix it
first.

Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]