https://bugzilla.redhat.com/show_bug.cgi?id=1059803 --- Comment #2 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- (In reply to Michael Scherer from comment #1) > Hi, > so : > - BuildRoot is no longer used > - the license should be shipped in %doc > - %changelog is empty > - rm -rf %{buildroot} in %install is not needed Thanks. I've updated it in: http://people.redhat.com/nmavrogi/fedora/ > - adding a few others files for documentation would be nice I plan to add a manpage or so as well. > - why does it buildRequires curl and perl It does need them for make check (which is now executed) > - %configure CFLAGS="-I/usr/include/libev" > seems wrong, since it erase the CFLAGS set by configure. I removed that completely by patching it to use pkg-config. > - why is there a patch, was it sent upstream ? ( cause I see it fix various > bugs, but we should document the fact it was sent upstream if that's the > case, and send it if that's not the case ( and go back to case 1 )) Indeed, I'm in contact with upstream. The version added will most probably have some of the changes at upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review