https://bugzilla.redhat.com/show_bug.cgi?id=1059803 --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- Hi, so : - BuildRoot is no longer used - the license should be shipped in %doc - adding a few others files for documentation would be nice - %changelog is empty - rm -rf %{buildroot} in %install is not needed - why does it buildRequires curl and perl - %configure CFLAGS="-I/usr/include/libev" seems wrong, since it erase the CFLAGS set by configure. Try instead : export CFLAGS="-I/usr/include/libev" %configure - why is there a patch, was it sent upstream ? ( cause I see it fix various bugs, but we should document the fact it was sent upstream if that's the case, and send it if that's not the case ( and go back to case 1 )) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review