https://bugzilla.redhat.com/show_bug.cgi?id=1057849 --- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> --- (In reply to Christopher Meng from comment #1) > 1. Permissions on files are set properly. Fixed > 2. Please double check them. ... I did. What exactly do you believe is incorrect here? A seemingly random list of files some of which don't get built is not particularly helpful here. > > 3. Requires > -------- > coreboot-utils (rpmlib, GLIBC filtered): > libc.so.6 > libpci.so.3 > libpci.so.3(LIBPCI_3.0) > libpci.so.3(LIBPCI_3.2) > libz.so.1 > rtld(GNU_HASH) > > ---------------------> MISSING: zlib-devel pciutils-devel drags this in transitively. > 4. Do we need to do this? Because we're replacing superiotool? > Provides: superiotool = %{version} > > There is no version of it at all, BTW it has become a part of coreboot. The version being the same as package is a common practice to ensure possibility of future obsoletes. Unversioned provide is a complete no-go according to the guidelines. > Also, both of the obsoletes/provides miss -%{release} appended. Added to provides. > 5. The way generating sources is still not clear. repo URL? Stable version? > Snapshot package? My fault. Should be fixed. > 6. Static linking. > > [rpmaker@fab util]$ grep -e "-static" * -r > dump_mmcr/Makefile: gcc -m32 -Os -static -o dumpmmcr dumpmmcr.c > ================================================== > ||k8resdump/Makefile:LDFLAGS = -lpci -lz -static || > ================================================== > mkelfImage/configure.ac:I386_LDFLAGS='-static --warn-multiple-gp > --warn-common' > mkelfImage/configure.ac:IA64_LDFLAGS='-static --warn-multiple-gp > --warn-common' > mkelfImage/configure:I386_LDFLAGS='-static --warn-multiple-gp --warn-common' > mkelfImage/configure:IA64_LDFLAGS='-static --warn-multiple-gp --warn-common' > > Why are they static linked? Need to patch out. They're not. This is not used during the build and is completely irrelevant. > 7. Why we need these? Because install sets the permissions incorrectly on some manuals. > %attr(0644,-,-) %{_mandir}/man1/* > %attr(0644,-,-) %{_mandir}/man8/* > > Can't you do the chmod in %install? We should avoid using %attr nowadays. I believe this is more concise. Why do you thing we should avoid it? SPEC: http://v3.sk/~lkundrak/SPECS/coreboot-utils.spec SRPM: http://v3.sk/~lkundrak/SRPMS/coreboot-utils-4.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review