https://bugzilla.redhat.com/show_bug.cgi?id=1057849 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Issues: ======= 1. Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions Rpmlint ------- Checking: coreboot-utils-4.0-1.fc21.i686.rpm coreboot-utils-4.0-1.fc21.src.rpm coreboot-utils.i686: E: incorrect-fsf-address /usr/share/doc/coreboot-utils/COPYING.mkelfImage coreboot-utils.i686: E: non-standard-executable-perm /usr/sbin/mkelfImage 0775L coreboot-utils.i686: W: no-manual-page-for-binary ectool coreboot-utils.i686: W: no-manual-page-for-binary msrtool coreboot-utils.src: W: invalid-url Source0: coreboot-utils-4.0.tar.gz 2 packages and 0 specfiles checked; 2 errors, 3 warnings. 2. Please double check them. License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated", "BSD (3 clause)", "GPL (unversioned/unknown version)", "BSD (2 clause)", "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2) (with incorrect FSF address)", "LGPL (v2.1 or later)", "GPL (v2)". 322 files have unknown license. Detailed output of licensecheck: *No copyright* GPL (v2 or later) (with incorrect FSF address) ------------------------------------------------------------- coreboot-utils-4.0/util/kconfig/lxdialog/checklist.c coreboot-utils-4.0/util/kconfig/lxdialog/dialog.h coreboot-utils-4.0/util/kconfig/lxdialog/inputbox.c coreboot-utils-4.0/util/kconfig/lxdialog/menubox.c coreboot-utils-4.0/util/kconfig/lxdialog/textbox.c coreboot-utils-4.0/util/kconfig/lxdialog/util.c coreboot-utils-4.0/util/kconfig/lxdialog/yesno.c BSD (2 clause) -------------- coreboot-utils-4.0/util/nvramtool/hexdump.c coreboot-utils-4.0/util/nvramtool/hexdump.h BSD (3 clause) -------------- coreboot-utils-4.0/util/crossgcc/getopt.c coreboot-utils-4.0/util/mptable/mptable.c GPL --- coreboot-utils-4.0/util/k8resdump/k8resdump.c coreboot-utils-4.0/util/nvramtool/cmos_lowlevel.c coreboot-utils-4.0/util/nvramtool/cmos_lowlevel.h coreboot-utils-4.0/util/nvramtool/cmos_ops.c coreboot-utils-4.0/util/nvramtool/cmos_ops.h coreboot-utils-4.0/util/nvramtool/common.c coreboot-utils-4.0/util/nvramtool/common.h coreboot-utils-4.0/util/nvramtool/input_file.c coreboot-utils-4.0/util/nvramtool/input_file.h coreboot-utils-4.0/util/nvramtool/layout.c coreboot-utils-4.0/util/nvramtool/layout.h coreboot-utils-4.0/util/nvramtool/layout_file.c coreboot-utils-4.0/util/nvramtool/layout_file.h coreboot-utils-4.0/util/nvramtool/lbtable.c coreboot-utils-4.0/util/nvramtool/lbtable.h coreboot-utils-4.0/util/nvramtool/nvramtool.c coreboot-utils-4.0/util/nvramtool/opts.c coreboot-utils-4.0/util/nvramtool/opts.h coreboot-utils-4.0/util/nvramtool/reg_expr.c coreboot-utils-4.0/util/nvramtool/reg_expr.h GPL (unversioned/unknown version) --------------------------------- coreboot-utils-4.0/util/nrv2b/nrv2b.c GPL (v2 or later) ----------------- coreboot-utils-4.0/util/cbfstool/lzma/Makefile.inc coreboot-utils-4.0/util/cbfstool/lzma/minilzma.cc coreboot-utils-4.0/util/optionlist/Options-wiki.xsl coreboot-utils-4.0/util/optionlist/Options.xsl coreboot-utils-4.0/util/optionlist/mkOptionList.py coreboot-utils-4.0/util/superiotool/ali.c coreboot-utils-4.0/util/superiotool/fintek.c coreboot-utils-4.0/util/superiotool/ite.c coreboot-utils-4.0/util/superiotool/nsc.c coreboot-utils-4.0/util/superiotool/pci.c coreboot-utils-4.0/util/superiotool/smsc.c coreboot-utils-4.0/util/superiotool/superiotool.c coreboot-utils-4.0/util/superiotool/superiotool.h coreboot-utils-4.0/util/superiotool/via.c coreboot-utils-4.0/util/superiotool/winbond.c coreboot-utils-4.0/util/x86emu/Makefile.inc coreboot-utils-4.0/util/x86emu/biosemu.c GPL (v2 or later) (with incorrect FSF address) ---------------------------------------------- coreboot-utils-4.0/util/dump_mmcr/dumpmmcr.c coreboot-utils-4.0/util/kconfig/regex.c coreboot-utils-4.0/util/kconfig/regex.h GPL (v2) -------- coreboot-utils-4.0/util/cbfstool/cbfs-mkpayload.c coreboot-utils-4.0/util/cbfstool/cbfs-mkstage.c coreboot-utils-4.0/util/cbfstool/cbfs.h coreboot-utils-4.0/util/cbfstool/cbfstool.c coreboot-utils-4.0/util/cbfstool/common.c coreboot-utils-4.0/util/cbfstool/common.h coreboot-utils-4.0/util/cbfstool/compress.c coreboot-utils-4.0/util/ectool/ec.c coreboot-utils-4.0/util/ectool/ec.h coreboot-utils-4.0/util/ectool/ectool.c coreboot-utils-4.0/util/msrtool/cs5536.c coreboot-utils-4.0/util/msrtool/darwin.c coreboot-utils-4.0/util/msrtool/freebsd.c coreboot-utils-4.0/util/msrtool/geodegx2.c coreboot-utils-4.0/util/msrtool/geodelx.c coreboot-utils-4.0/util/msrtool/k8.c coreboot-utils-4.0/util/msrtool/linux.c coreboot-utils-4.0/util/msrtool/msrtool.c coreboot-utils-4.0/util/msrtool/msrtool.h coreboot-utils-4.0/util/msrtool/msrutils.c coreboot-utils-4.0/util/msrtool/sys.c coreboot-utils-4.0/util/x86emu/x86.c coreboot-utils-4.0/util/x86emu/x86_interrupts.c GPL (v2) (with incorrect FSF address) ------------------------------------- coreboot-utils-4.0/util/inteltool/cpu.c coreboot-utils-4.0/util/inteltool/gpio.c coreboot-utils-4.0/util/inteltool/inteltool.c coreboot-utils-4.0/util/inteltool/inteltool.h coreboot-utils-4.0/util/inteltool/memory.c coreboot-utils-4.0/util/inteltool/pcie.c coreboot-utils-4.0/util/inteltool/powermgt.c coreboot-utils-4.0/util/inteltool/rootcmplx.c LGPL (v2.1 or later) -------------------- coreboot-utils-4.0/util/cbfstool/elf.h Unknown or generated -------------------- coreboot-utils-4.0/util/amdtools/k8-compare-pci-space.pl coreboot-utils-4.0/util/amdtools/k8-interpret-extended-memory-settings.pl coreboot-utils-4.0/util/amdtools/k8-read-mem-settings.sh coreboot-utils-4.0/util/amdtools/parse-bkdg.pl coreboot-utils-4.0/util/cbfstool/Makefile.inc coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Common/InBuffer.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Common/OutBuffer.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Common/OutBuffer.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Common/StdAfx.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Common/StreamUtils.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Common/StreamUtils.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/BinTree/BinTree.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/BinTree/BinTree2.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/BinTree/BinTree3.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/BinTree/BinTree4.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/BinTree/BinTreeMain.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/HashChain/HC4.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/HashChain/HCMain.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/IMatchFinder.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/LZInWindow.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/LZInWindow.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZ/StdAfx.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZMA/LZMA.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZMA/LZMAEncoder.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZMA/LZMAEncoder.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/LZMA/StdAfx.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/RangeCoder/RangeCoder.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/RangeCoder/RangeCoderBit.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/RangeCoder/RangeCoderBit.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/RangeCoder/RangeCoderBitTree.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/RangeCoder/RangeCoderOpt.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Compress/RangeCoder/StdAfx.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Decompress/LzmaDecode.c coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/Decompress/LzmaDecode.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/ICoder.h coreboot-utils-4.0/util/cbfstool/lzma/C/7zip/IStream.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/Alloc.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/Common/Alloc.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/CRC.cpp coreboot-utils-4.0/util/cbfstool/lzma/C/Common/CRC.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/Defs.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/MyCom.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/MyGuidDef.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/MyInitGuid.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/MyUnknown.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/MyWindows.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/NewHandler.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/StdAfx.h coreboot-utils-4.0/util/cbfstool/lzma/C/Common/Types.h coreboot-utils-4.0/util/getpir/checkpir.c coreboot-utils-4.0/util/getpir/checksum.c coreboot-utils-4.0/util/getpir/checksum.h coreboot-utils-4.0/util/getpir/code_gen.c coreboot-utils-4.0/util/getpir/code_gen.h coreboot-utils-4.0/util/getpir/getpir.c coreboot-utils-4.0/util/getpir/pirq_routing.h coreboot-utils-4.0/util/kconfig/check.sh coreboot-utils-4.0/util/kconfig/conf.c coreboot-utils-4.0/util/kconfig/confdata.c coreboot-utils-4.0/util/kconfig/expr.c coreboot-utils-4.0/util/kconfig/expr.h coreboot-utils-4.0/util/kconfig/gconf.c coreboot-utils-4.0/util/kconfig/images.c coreboot-utils-4.0/util/kconfig/kconfig_load.c coreboot-utils-4.0/util/kconfig/kxgettext.c coreboot-utils-4.0/util/kconfig/lkc.h coreboot-utils-4.0/util/kconfig/lkc_proto.h coreboot-utils-4.0/util/kconfig/lxdialog/check-lxdialog.sh coreboot-utils-4.0/util/kconfig/mconf.c coreboot-utils-4.0/util/kconfig/menu.c coreboot-utils-4.0/util/kconfig/qconf.cc coreboot-utils-4.0/util/kconfig/qconf.h coreboot-utils-4.0/util/kconfig/symbol.c coreboot-utils-4.0/util/kconfig/util.c coreboot-utils-4.0/util/lbtdump/lbtdump.c coreboot-utils-4.0/util/mkelfImage/arch/i386/include/arch/io.h coreboot-utils-4.0/util/mkelfImage/arch/i386/include/limits.h coreboot-utils-4.0/util/mkelfImage/arch/i386/include/stdint.h coreboot-utils-4.0/util/mkelfImage/arch/ia64/include/limits.h coreboot-utils-4.0/util/mkelfImage/arch/ia64/include/stdint.h coreboot-utils-4.0/util/mkelfImage/include/elf.h coreboot-utils-4.0/util/mkelfImage/include/elf_boot.h coreboot-utils-4.0/util/mkelfImage/include/linuxbios_tables.h coreboot-utils-4.0/util/mkelfImage/include/mkelfImage.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/arch/alpha/include/stddef.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/arch/alpha/include/stdint.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/arch/alpha/include/va-alpha.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/arch/i386/include/stddef.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/arch/i386/include/stdint.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/include/stdarg.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/include/stdlib.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/include/string.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/include/types.h coreboot-utils-4.0/util/mkelfImage/kunzip_src/lib/inflate.c coreboot-utils-4.0/util/mkelfImage/kunzip_src/lib/kunzip.c coreboot-utils-4.0/util/mkelfImage/kunzip_src/lib/malloc.c coreboot-utils-4.0/util/mkelfImage/kunzip_src/lib/memcmp.c coreboot-utils-4.0/util/mkelfImage/kunzip_src/lib/memcpy.c coreboot-utils-4.0/util/mkelfImage/kunzip_src/lib/memset.c coreboot-utils-4.0/util/mkelfImage/linux-i386/convert.bin.c coreboot-utils-4.0/util/mkelfImage/linux-i386/convert.h coreboot-utils-4.0/util/mkelfImage/linux-i386/convert_params.c coreboot-utils-4.0/util/mkelfImage/linux-i386/mkelf-linux-i386.c coreboot-utils-4.0/util/mkelfImage/linux-i386/uniform_boot.h coreboot-utils-4.0/util/mkelfImage/linux-i386/x86-linux.h coreboot-utils-4.0/util/mkelfImage/linux-ia64/convert.bin.c coreboot-utils-4.0/util/mkelfImage/linux-ia64/convert.h coreboot-utils-4.0/util/mkelfImage/linux-ia64/convert_params.c coreboot-utils-4.0/util/mkelfImage/linux-ia64/mkelf-linux-ia64.c coreboot-utils-4.0/util/mkelfImage/main/mkelfImage.c coreboot-utils-4.0/util/mkelfImage/util/bin-to-hex.c coreboot-utils-4.0/util/nvramtool/compute_ip_checksum.c coreboot-utils-4.0/util/nvramtool/coreboot_tables.h coreboot-utils-4.0/util/nvramtool/ip_checksum.h coreboot-utils-4.0/util/options/build_opt_tbl.c coreboot-utils-4.0/util/resetcf/resetcf.c coreboot-utils-4.0/util/romcc/do_tests.sh coreboot-utils-4.0/util/romcc/romcc.c coreboot-utils-4.0/util/romcc/tests.sh coreboot-utils-4.0/util/romcc/tests/fail_test1.c coreboot-utils-4.0/util/romcc/tests/fail_test10.c coreboot-utils-4.0/util/romcc/tests/fail_test11.c coreboot-utils-4.0/util/romcc/tests/fail_test2.c coreboot-utils-4.0/util/romcc/tests/fail_test3.c coreboot-utils-4.0/util/romcc/tests/fail_test4.c coreboot-utils-4.0/util/romcc/tests/fail_test5.c coreboot-utils-4.0/util/romcc/tests/fail_test6.c coreboot-utils-4.0/util/romcc/tests/fail_test7.c coreboot-utils-4.0/util/romcc/tests/fail_test8.c coreboot-utils-4.0/util/romcc/tests/fail_test9.c coreboot-utils-4.0/util/romcc/tests/hello_world.c coreboot-utils-4.0/util/romcc/tests/hello_world1.c coreboot-utils-4.0/util/romcc/tests/hello_world2.c coreboot-utils-4.0/util/romcc/tests/include/linux_console.h coreboot-utils-4.0/util/romcc/tests/include/linux_syscall.h coreboot-utils-4.0/util/romcc/tests/include/linuxi386_syscall.h coreboot-utils-4.0/util/romcc/tests/linux_console.h coreboot-utils-4.0/util/romcc/tests/linux_syscall.h coreboot-utils-4.0/util/romcc/tests/linux_test1.c coreboot-utils-4.0/util/romcc/tests/linux_test10.c coreboot-utils-4.0/util/romcc/tests/linux_test11.c coreboot-utils-4.0/util/romcc/tests/linux_test12.c coreboot-utils-4.0/util/romcc/tests/linux_test13.c coreboot-utils-4.0/util/romcc/tests/linux_test2.c coreboot-utils-4.0/util/romcc/tests/linux_test3.c coreboot-utils-4.0/util/romcc/tests/linux_test4.c coreboot-utils-4.0/util/romcc/tests/linux_test5.c coreboot-utils-4.0/util/romcc/tests/linux_test6.c coreboot-utils-4.0/util/romcc/tests/linux_test7.c coreboot-utils-4.0/util/romcc/tests/linux_test8.c coreboot-utils-4.0/util/romcc/tests/linux_test9.c coreboot-utils-4.0/util/romcc/tests/linuxi386_syscall.h coreboot-utils-4.0/util/romcc/tests/raminit_test.c coreboot-utils-4.0/util/romcc/tests/raminit_test1.c coreboot-utils-4.0/util/romcc/tests/raminit_test2.c coreboot-utils-4.0/util/romcc/tests/raminit_test3.c coreboot-utils-4.0/util/romcc/tests/raminit_test4.c coreboot-utils-4.0/util/romcc/tests/raminit_test5.c coreboot-utils-4.0/util/romcc/tests/raminit_test6.c coreboot-utils-4.0/util/romcc/tests/raminit_test7.c coreboot-utils-4.0/util/romcc/tests/simple_test.c coreboot-utils-4.0/util/romcc/tests/simple_test1.c coreboot-utils-4.0/util/romcc/tests/simple_test10.c coreboot-utils-4.0/util/romcc/tests/simple_test11.c coreboot-utils-4.0/util/romcc/tests/simple_test12.c coreboot-utils-4.0/util/romcc/tests/simple_test13.c coreboot-utils-4.0/util/romcc/tests/simple_test14.c coreboot-utils-4.0/util/romcc/tests/simple_test15.c coreboot-utils-4.0/util/romcc/tests/simple_test16.c coreboot-utils-4.0/util/romcc/tests/simple_test17.c coreboot-utils-4.0/util/romcc/tests/simple_test18.c coreboot-utils-4.0/util/romcc/tests/simple_test19.c coreboot-utils-4.0/util/romcc/tests/simple_test2.c coreboot-utils-4.0/util/romcc/tests/simple_test20.c coreboot-utils-4.0/util/romcc/tests/simple_test21.c coreboot-utils-4.0/util/romcc/tests/simple_test22.c coreboot-utils-4.0/util/romcc/tests/simple_test23.c coreboot-utils-4.0/util/romcc/tests/simple_test24.c coreboot-utils-4.0/util/romcc/tests/simple_test25.c coreboot-utils-4.0/util/romcc/tests/simple_test26.c coreboot-utils-4.0/util/romcc/tests/simple_test27.c coreboot-utils-4.0/util/romcc/tests/simple_test28.c coreboot-utils-4.0/util/romcc/tests/simple_test29.c coreboot-utils-4.0/util/romcc/tests/simple_test3.c coreboot-utils-4.0/util/romcc/tests/simple_test30.c coreboot-utils-4.0/util/romcc/tests/simple_test31.c coreboot-utils-4.0/util/romcc/tests/simple_test32.c coreboot-utils-4.0/util/romcc/tests/simple_test33.c coreboot-utils-4.0/util/romcc/tests/simple_test34.c coreboot-utils-4.0/util/romcc/tests/simple_test35.c coreboot-utils-4.0/util/romcc/tests/simple_test36.c coreboot-utils-4.0/util/romcc/tests/simple_test37.c coreboot-utils-4.0/util/romcc/tests/simple_test38.c coreboot-utils-4.0/util/romcc/tests/simple_test39.c coreboot-utils-4.0/util/romcc/tests/simple_test4.c coreboot-utils-4.0/util/romcc/tests/simple_test40.c coreboot-utils-4.0/util/romcc/tests/simple_test41.c coreboot-utils-4.0/util/romcc/tests/simple_test43.c coreboot-utils-4.0/util/romcc/tests/simple_test45.c coreboot-utils-4.0/util/romcc/tests/simple_test46.c coreboot-utils-4.0/util/romcc/tests/simple_test47.c coreboot-utils-4.0/util/romcc/tests/simple_test48.c coreboot-utils-4.0/util/romcc/tests/simple_test49.c coreboot-utils-4.0/util/romcc/tests/simple_test5.c coreboot-utils-4.0/util/romcc/tests/simple_test50.c coreboot-utils-4.0/util/romcc/tests/simple_test51.c coreboot-utils-4.0/util/romcc/tests/simple_test52.c coreboot-utils-4.0/util/romcc/tests/simple_test53.c coreboot-utils-4.0/util/romcc/tests/simple_test54.c coreboot-utils-4.0/util/romcc/tests/simple_test55.c coreboot-utils-4.0/util/romcc/tests/simple_test56.c coreboot-utils-4.0/util/romcc/tests/simple_test57.c coreboot-utils-4.0/util/romcc/tests/simple_test58.c coreboot-utils-4.0/util/romcc/tests/simple_test59.c coreboot-utils-4.0/util/romcc/tests/simple_test6.c coreboot-utils-4.0/util/romcc/tests/simple_test60.c coreboot-utils-4.0/util/romcc/tests/simple_test61.c coreboot-utils-4.0/util/romcc/tests/simple_test62.c coreboot-utils-4.0/util/romcc/tests/simple_test63.c coreboot-utils-4.0/util/romcc/tests/simple_test64.c coreboot-utils-4.0/util/romcc/tests/simple_test65.c coreboot-utils-4.0/util/romcc/tests/simple_test66.c coreboot-utils-4.0/util/romcc/tests/simple_test67.c coreboot-utils-4.0/util/romcc/tests/simple_test68.c coreboot-utils-4.0/util/romcc/tests/simple_test69.c coreboot-utils-4.0/util/romcc/tests/simple_test7.c coreboot-utils-4.0/util/romcc/tests/simple_test70.c coreboot-utils-4.0/util/romcc/tests/simple_test71.c coreboot-utils-4.0/util/romcc/tests/simple_test72.c coreboot-utils-4.0/util/romcc/tests/simple_test73.c coreboot-utils-4.0/util/romcc/tests/simple_test74.c coreboot-utils-4.0/util/romcc/tests/simple_test75.c coreboot-utils-4.0/util/romcc/tests/simple_test76.c coreboot-utils-4.0/util/romcc/tests/simple_test77.c coreboot-utils-4.0/util/romcc/tests/simple_test78.c coreboot-utils-4.0/util/romcc/tests/simple_test79.c coreboot-utils-4.0/util/romcc/tests/simple_test8.c coreboot-utils-4.0/util/romcc/tests/simple_test80.c coreboot-utils-4.0/util/romcc/tests/simple_test81.c coreboot-utils-4.0/util/romcc/tests/simple_test82.c coreboot-utils-4.0/util/romcc/tests/simple_test83.c coreboot-utils-4.0/util/romcc/tests/simple_test84.c coreboot-utils-4.0/util/romcc/tests/simple_test85.c coreboot-utils-4.0/util/romcc/tests/simple_test86.c coreboot-utils-4.0/util/romcc/tests/simple_test9.c coreboot-utils-4.0/util/sconfig/yapps2.py coreboot-utils-4.0/util/sconfig/yapps2.tex coreboot-utils-4.0/util/sconfig/yappsrt.py coreboot-utils-4.0/util/vgabios/helper_exec.c coreboot-utils-4.0/util/vgabios/helper_exec.h coreboot-utils-4.0/util/vgabios/helper_mem.c coreboot-utils-4.0/util/vgabios/int10.c coreboot-utils-4.0/util/vgabios/int15.c coreboot-utils-4.0/util/vgabios/int16.c coreboot-utils-4.0/util/vgabios/int1a.c coreboot-utils-4.0/util/vgabios/inte6.c coreboot-utils-4.0/util/vgabios/pci-userspace.c coreboot-utils-4.0/util/vgabios/pci-userspace.h coreboot-utils-4.0/util/vgabios/pci.h coreboot-utils-4.0/util/vgabios/test.h coreboot-utils-4.0/util/vgabios/testbios.c coreboot-utils-4.0/util/vgabios/x86emu/include/msr.h coreboot-utils-4.0/util/vgabios/x86emu/include/x86emu.h coreboot-utils-4.0/util/vgabios/x86emu/include/x86emu/fpu_regs.h coreboot-utils-4.0/util/vgabios/x86emu/include/x86emu/regs.h coreboot-utils-4.0/util/vgabios/x86emu/include/x86emu/types.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/debug.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/decode.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/fpu.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/ops.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/ops2.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/prim_ops.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/sys.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/validate.c coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/debug.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/decode.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/fpu.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/ops.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/prim_asm.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/prim_ops.h coreboot-utils-4.0/util/vgabios/x86emu/src/x86emu/x86emu/x86emui.h coreboot-utils-4.0/util/x86emu/include/x86emu/fpu_regs.h coreboot-utils-4.0/util/x86emu/include/x86emu/regs.h coreboot-utils-4.0/util/x86emu/include/x86emu/types.h coreboot-utils-4.0/util/x86emu/include/x86emu/x86emu.h coreboot-utils-4.0/util/x86emu/x86emu/Makefile.inc coreboot-utils-4.0/util/x86emu/x86emu/debug.c coreboot-utils-4.0/util/x86emu/x86emu/debug.h coreboot-utils-4.0/util/x86emu/x86emu/decode.c coreboot-utils-4.0/util/x86emu/x86emu/decode.h coreboot-utils-4.0/util/x86emu/x86emu/fpu.c coreboot-utils-4.0/util/x86emu/x86emu/fpu.h coreboot-utils-4.0/util/x86emu/x86emu/ops.c coreboot-utils-4.0/util/x86emu/x86emu/ops.h coreboot-utils-4.0/util/x86emu/x86emu/ops2.c coreboot-utils-4.0/util/x86emu/x86emu/prim_asm.h coreboot-utils-4.0/util/x86emu/x86emu/prim_ops.c coreboot-utils-4.0/util/x86emu/x86emu/prim_ops.h coreboot-utils-4.0/util/x86emu/x86emu/sys.c coreboot-utils-4.0/util/x86emu/x86emu/x86emui.h coreboot-utils-4.0/util/x86emu/yabel/Makefile.inc coreboot-utils-4.0/util/x86emu/yabel/biosemu.c coreboot-utils-4.0/util/x86emu/yabel/biosemu.h coreboot-utils-4.0/util/x86emu/yabel/compat/Makefile.inc coreboot-utils-4.0/util/x86emu/yabel/compat/functions.c coreboot-utils-4.0/util/x86emu/yabel/compat/of.h coreboot-utils-4.0/util/x86emu/yabel/compat/rtas.h coreboot-utils-4.0/util/x86emu/yabel/compat/time.h coreboot-utils-4.0/util/x86emu/yabel/debug.c coreboot-utils-4.0/util/x86emu/yabel/debug.h coreboot-utils-4.0/util/x86emu/yabel/device.c coreboot-utils-4.0/util/x86emu/yabel/device.h coreboot-utils-4.0/util/x86emu/yabel/interrupt.c coreboot-utils-4.0/util/x86emu/yabel/interrupt.h coreboot-utils-4.0/util/x86emu/yabel/io.c coreboot-utils-4.0/util/x86emu/yabel/io.h coreboot-utils-4.0/util/x86emu/yabel/mem.c coreboot-utils-4.0/util/x86emu/yabel/mem.h coreboot-utils-4.0/util/x86emu/yabel/pmm.c coreboot-utils-4.0/util/x86emu/yabel/pmm.h coreboot-utils-4.0/util/x86emu/yabel/vbe.c coreboot-utils-4.0/util/x86emu/yabel/vbe.h 3. Requires -------- coreboot-utils (rpmlib, GLIBC filtered): libc.so.6 libpci.so.3 libpci.so.3(LIBPCI_3.0) libpci.so.3(LIBPCI_3.2) libz.so.1 rtld(GNU_HASH) ---------------------> MISSING: zlib-devel 4. Do we need to do this? Provides: superiotool = %{version} There is no version of it at all, BTW it has become a part of coreboot. Also, both of the obsoletes/provides miss -%{release} appended. 5. The way generating sources is still not clear. repo URL? Stable version? Snapshot package? 6. Static linking. [rpmaker@fab util]$ grep -e "-static" * -r dump_mmcr/Makefile: gcc -m32 -Os -static -o dumpmmcr dumpmmcr.c ================================================== ||k8resdump/Makefile:LDFLAGS = -lpci -lz -static || ================================================== mkelfImage/configure.ac:I386_LDFLAGS='-static --warn-multiple-gp --warn-common' mkelfImage/configure.ac:IA64_LDFLAGS='-static --warn-multiple-gp --warn-common' mkelfImage/configure:I386_LDFLAGS='-static --warn-multiple-gp --warn-common' mkelfImage/configure:IA64_LDFLAGS='-static --warn-multiple-gp --warn-common' Why are they static linked? Need to patch out. 7. Why we need these? %attr(0644,-,-) %{_mandir}/man1/* %attr(0644,-,-) %{_mandir}/man8/* Can't you do the chmod in %install? We should avoid using %attr nowadays. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review