https://bugzilla.redhat.com/show_bug.cgi?id=1030751 Pete Travis <me@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ | --- Comment #11 from Pete Travis <me@xxxxxxxxxxxxxx> --- (In reply to Michael Schwendt from comment #10) > Great! Thanks, Michael. I appreciate you taking the time to help me understand this. > > > [x]: Package does not own files or directories owned by other packages. > > Note: Dirs in package are owned also by: /usr/lib/python3.3/site- > > packages/__pycache__(python3-setuptools, python3-libs) > > What this item on the list means is: The fedora-review tool found > directories in the package, which are owned by other packages already. That > refers to the following part of the guidelines: > > > https://fedoraproject.org/wiki/Packaging: > Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_fun > ctionality_of_your_package > > > -- Owns it's own files in cited directories, > > It should _not_ own /usr/lib/python3.3/site-packages/__pycache__ because > that one belongs into python3-libs already. > > Co-ownership of directories can become a problem, if one package messes up > the file access permissions, for example. That's why the guidelines still > try to reduce co-ownership to the exceptional cases: > https://fedoraproject.org/wiki/Packaging: > Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your > _package_to_function My thinking here was that the "__pycache__"" directory wasn't present in the source tarball, and was claimed via the "%{python3_sitelib}/*" glob, so it was a result of the build process and safe to glob, similar to the py2 glob that didn't throw a warning or even pyc,pyo files that aren't shipped but generated. I'll read up on this, and certainly remember it. Christopher, please adjust for this. > > [...] > > Not related to the Review Guidelines, but to: > https://fedoraproject.org/wiki/Examples_of_good_package_summaries > > > Summary: A pure python bbcode parser and formatter > > My alternative suggestion that also eliminates the lower-case spelling of > everything: > > Summary: BBCode parser and formatter written in Python I prefer your suggestion too, but the existing summary matches upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review