https://bugzilla.redhat.com/show_bug.cgi?id=1051771 --- Comment #10 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Mohamed El Morabity from comment #8) > Hello, > > some comments: > > - it looks like the package doesn't build on F20 and Rawhide: > http://koji.fedoraproject.org/koji/taskinfo?taskID=6457561 (rawhide) > http://koji.fedoraproject.org/koji/taskinfo?taskID=6457430 (F20) > > You try to build vdr-tvguide against graphicsmagick: > make CFLAGS="%{optflags}" IMAGELIB=graphicsmagick %{?_smp_mflags} all > whereas your package depends on ImageMagick-c++-devel. As a result, drop > "IMAGELIB=..." to link against ImageMagick (this seems to be the default), > or replace your BR on ImageMagick-c++-devel by GraphicsMagick-c++-devel if > you have a reason to use GraphicsMagick instead. I replaced ImageMagick as requirement due big dependencies through GraphicsMagick > - since the package is written in C++, and since the CXXFLAGS variable is > handled by the plugin Makefile, you must also set CXXFLAGS when calling > make, to keep consistency on build flags: > make CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" ... > You should even add -fPIC to both CFLAGS and CXXFLAGS to handle build > issues on x86_64 platforms. done > > - a stable release 1.0.0 is available. Why do you need to use a development > snapshot? because it is the current version and includes all necessary patches and more features. > - I wonder if a subpackage for themes is really necessary: > * the data subpackage is not very heavy > * the subpackage is useless "standalone" > * I don't think the data subpackage would be required by any other package > than vdr-tvguide. removed the data subpackage > - The license tag should be set to GPLv2+ also (see COPYING file and license > - headers refering to GPLv2 or later in source files). done Spec URL: https://dl.dropboxusercontent.com/s/d1u3vl780ovey8s/vdr-tvguide.spec SRPM URL: https://dl.dropboxusercontent.com/s/qt4uo8ej1tcvzdl/vdr-tvguide-1.0.0-10.20140126git5eabb6e.fc20.src.rpm %changelog * Mon Jan 27 2014 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 1.0.0-10.20140126git5eabb6e - rebuild for new git release - added correct license tag - removed data subpackage - removed ImageMagick-c++-devel package - added GraphicsMagick-c++-devel package - added CXXFLAGS and -fPIC build flag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review