[Bug 1057670] Review Request: jetty8 - jetty compatibility package (libs only)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1057670



--- Comment #3 from Pete MacKinnon <pmackinn@xxxxxxxxxx> ---
Spec URL: http://pmackinn.fedorapeople.org/jetty8/jetty8.spec
SRPM URL: http://pmackinn.fedorapeople.org/jetty8/jetty8-8.1.14-2.fc21.src.rpm

1) You should use %mvn_install to install artifacts.
DONE

2) Requires are incorrect (they still require Jetty 9.x modules), you should
drop explicit requres and rely on autorequires.
Think I got this right:

$ rpm -qp --requires jetty8-server-8.1.14-2.fc21.noarch.rpm
java >= 1:1.6
jpackage-utils
mvn(org.eclipse.jetty.orbit:javax.servlet)
mvn(org.eclipse.jetty:jetty-continuation) = 8.1.14.v20131031
mvn(org.eclipse.jetty:jetty-http) = 8.1.14.v20131031
mvn(org.eclipse.jetty:jetty-jmx) = 8.1.14.v20131031
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -qp --provides jetty8-server-8.1.14-2.fc21.noarch.rpm
jetty8-server = 8.1.14-2.fc21
mvn(org.eclipse.jetty:jetty-server) = 8.1.14.v20131031
osgi(org.eclipse.jetty.server) = 8.1.14

3) %pre, %post, %preun, %postun are not needed and should be removed.
DONE

5) Unneeded modules (like OSGi and NoSQL) should be removed together with all
the conditional cruft.
DONE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]