[Bug 1057670] Review Request: jetty8 - jetty compatibility package (libs only)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1057670

Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mizdebsk@xxxxxxxxxx



--- Comment #2 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> ---
Several issues:

1) You should use %mvn_install to install artifacts.

2) Requires are incorrect (they still require Jetty 9.x modules), you should
drop explicit requres and rely on autorequires.

3) %pre, %post, %preun, %postun are not needed and should be removed.

4) You should enable tests or document why they are skipped.

5) Unneeded modules (like OSGi and NoSQL) should be removed together with all
the conditional cruft.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]