[Bug 1055393] Review Request: ocaml-biniou - Safe and fast binary data format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1055393

Jerry James <loganjerry@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Michel Alexandre Salim from comment #3)
> Incorporated review feedbacks in -2, links and comments below.

#6 appears to have been missed:

6) Remove rm -rf $RPM_BUILD_ROOT from the top of %install.

But that's not a big deal.  Take care of it when you import the package.

> > 12) There is no man page for bdump.
> > 
> Yes, upstream doesn't seem to provide one

That's a SHOULD item, so does not block the review.

I see no further issues, so this package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]