https://bugzilla.redhat.com/show_bug.cgi?id=1055005 --- Comment #3 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to Sergio Pascual from comment #2) > Problems (blocker) > =================== > > * Naming: according to the guidelines[1] a snapshot package has a release > tage of the form "date-of-checkout vcs-name commit-id". In your case > something like 20140120gitc112d69 > > In addition, depending if the package is a pre relase or a post release, the > full version must be: > > # pre release > Release: 0.1.%{checkout}%{?dist} > > # post release > Release: 1.%{checkout}%{?dist} > > where checkout is > > %global checkout 20140120git%{shortcommit} > > Your package is a pre release, isn't it? Yup, and fixed (You are right. That said, I really dislike these GL when applied here. But that's another story). > * Python requires and bytecompiling: your package is python 3 based but the > python sources are installed in a private directory. Some of the things RPM > does for packages under python system directories aren't done (properly), > namely: > > - bytecompilling [2], RPM is using python 2.7 to generate the .pyc and .pyo > of your package. If you define > > %global __python %{__python3} > > RPM will use python3 for bytecompilling Thanks for good catch! Fixed. > - Python 3 runtime, your package does not have a Requires on python3. It's > generated automatically for packages under python system directory. I > haven't found a better way than an explicit > Requires: python(abi) = 3.3 Thanks again for good catch, fixed using >= 3.3 . Also added R: python3-gobject and R: gtk3 for the glib/gtk3 introspections stuff. Might be missing something more here... In case you wonder about it (?) I don't want to install this under the python system directory since it doesn't contain anything which should be used by other packages. > * Directories: if your package requires sudo to run (and I think it does), > it should Require it. That way /etc/sudoers.d is not unowned > Requires: sudo Indeed, fixed. > Non blocker > =========== > > I think primarely is a typo, I have only found "primarily" in my english > dictionary. No typo. Bad Englisch, not my native language. Fixed spec: http://leamas.fedorapeople.org/system-config-repo/2/system-config-repo.spec srpm: http://leamas.fedorapeople.org/system-config-repo/2/system-config-repo-0-0.2.20140117gitc112d69.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review